Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure consistent code fencing label for JSON examples #565

Closed
ghost opened this issue Mar 5, 2019 · 3 comments · Fixed by #803
Closed

ensure consistent code fencing label for JSON examples #565

ghost opened this issue Mar 5, 2019 · 3 comments · Fixed by #803

Comments

@ghost
Copy link

ghost commented Mar 5, 2019

I propose we standardize json for code fences in JSON examples to preserve visual consistency.
Here we use json. Here we use javascript. Here we use text. I am not using blame because I am angry, just to show the exact line number.
Without unifying it, you can see the blocks highlighted differently in the guides:

json

screen shot 2019-03-05 at 17 06 58

text

screen shot 2019-03-05 at 17 06 26

@acorncom
Copy link
Member

@efx this sounds great, would you have time to tackle it as well?

@ghost
Copy link
Author

ghost commented Mar 28, 2019

@acorncom sure thing. I presume this should go into master?

@acorncom
Copy link
Member

acorncom commented Apr 3, 2019

@efx sorry, this got lost in the notification flood on this end. Yep, master works well. If you want to go back and fix previous releases, that's fine as well, but we don't always do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant