Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we manage creating new version folders? #66

Closed
jenweber opened this issue May 28, 2018 · 3 comments
Closed

How should we manage creating new version folders? #66

jenweber opened this issue May 28, 2018 · 3 comments

Comments

@jenweber
Copy link
Contributor

jenweber commented May 28, 2018

Current behavior:
When we make a new folder of versions, we risk creating more work/losing valuable work when open PRs are still pointed at earlier versions. We also lose the git history.

Desired behavior:
We don't need to duplicate work when a new version is cut.

Options:

  • merge or close PRs before making a new version
  • make a "current" folder that holds the next version, and PRs always go there
  • ???
@chrismou
Copy link
Contributor

Personally I'd say the current directory makes more sense, as there'll always be times a PR isn't ready for the release and you don't want to be rushed into merging it to avoid work later.

As you say, if fixes all point at master, you only ever have to worry about backporting, and you can judge whether its worth it based on the importance. Typos, for example, could probably just be left in most cases

@sivakumar-kailasam
Copy link
Member

New features would need to be documented early in Dev cycle in the guides going forward since some of them require more time for review. Their content usually goes into n+2nd folder if 'n' is the current version of guides. This is an additional constraint to account for

@jenweber
Copy link
Contributor Author

Closing, this has been less of a problem now that 3.x guides have stabilized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants