Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quick-start): use props instead of args in route template code example #1065

Closed

Conversation

jayjayjpg
Copy link
Contributor

This updates the code example in the Quick Start section, explaining how to pass properties to a component to use the this. syntax instead of argument syntax @.

As far as I'm aware, properties are only prefixed with an @ when they refer to arguments passed into a component. In this code example the property model is used in a route's template though, therefore this.model should be used instead of @model.

@jayjayjpg jayjayjpg requested a review from a team September 13, 2019 15:06
@chancancode
Copy link
Contributor

This was an intentional change (#1044), part of emberjs/rfcs#523. As of emberjs/ember.js#18363, @model is a full-fledged argument passed into the route template (in addition to being on the JavaScript controller class as this.model). However, there is a bit of a temporary problem, in that this only works on canary at the moment, and the Octane blueprints have been updated to track beta releases recently. This should be resolved next week when beta switches to 3.14.

@jayjayjpg
Copy link
Contributor Author

@chancancode Thanks a lot for the detailed explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants