Issue 1599 - add --lang option to guide #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ijlee2 please review, thanks in advanced. |
ijlee2
reviewed
Jan 13, 2021
| @@ -31,10 +31,11 @@ you will have access to a new `ember` command in your terminal. | |||
| You can use the `ember new` command to create a new application. | |||
|
|
|||
| ```bash | |||
| ember new ember-quickstart | |||
| ember new ember-quickstart --lang en | |||
There was a problem hiding this comment.
Can we update the example language to en-US, to better match the one in the ember-new-lang RFC? I think this may also help distinguish the locale from en-UK, for example.
Suggested change
| ember new ember-quickstart --lang en | |
| ember new ember-quickstart --lang en-US |
(feel free to ignore this suggestion)
There was a problem hiding this comment.
Actually, the RFC does mention the example of just --lang en. I think what you have currently is okay. 👍🏼
ijlee2
reviewed
Jan 13, 2021
| ``` | ||
|
|
||
| This one command will create a new directory called `ember-quickstart` and set up a new Ember application inside of it. | ||
| The `--lang en` option sets the app's primary language to English to help improve [accessibility](../../accessibility/application-considerations/). |
There was a problem hiding this comment.
Suggested change
| The `--lang en` option sets the app's primary language to English to help improve [accessibility](../../accessibility/application-considerations/). | |
| The `--lang en-US` option sets the app's primary language to (US) English to help improve [accessibility](../../accessibility/application-considerations/). |
(feel free to ignore this suggestion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #1599 -does this wording look okay? please review.