Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: install latest guidemaker-ember-template to switch to shiki #1997

Merged
merged 20 commits into from
Jun 26, 2024

Conversation

IgnaceMaes
Copy link
Member

@IgnaceMaes IgnaceMaes commented Jan 24, 2024

  • Upgrades to the latest guidemaker and guidemaker-ember-template version
    • This includes sidebar improvements, switching to Shiki for gjs/gts syntax highlighting, ...
  • Also changed the code block langs to gjs where used, to test this.

Preview: https://deploy-preview-1997--ember-guides.netlify.app/release/routing/defining-your-routes/

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit e69dd5d
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/667bbbe563663600083c7f89
😎 Deploy Preview https://deploy-preview-1997--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IgnaceMaes IgnaceMaes changed the title deps: install latest guidemaker-ember-template to switch to shikiji deps: install latest guidemaker-ember-template to switch to shiki Feb 3, 2024
@IgnaceMaes
Copy link
Member Author

The breaking change since converting guidemaker and dependencies to a v2 addon is the Ember Data integration.

When switching a version via the dropdown it logs:

TypeError: Cannot read properties of undefined (reading 'queryRecord')

In guidemaker/controllers/version.

@mansona IIRC there were some Ember Data reexport magic in the v1 addon that were changed. Do you have an idea how to proceed here?

@IgnaceMaes IgnaceMaes marked this pull request as ready for review June 26, 2024 07:02
@IgnaceMaes
Copy link
Member Author

Upgrading to the latest guidemaker patch fixed this 🎉

Should be ready to go now!

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mansona mansona merged commit 67b1bfc into ember-learn:master Jun 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants