Change block parameter to clarify connection to yield (#81) #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will align super-rentals to changes made in the guides.
|rentals| is changed to |filterResults| to make its connection
to {{yield results}} more explicit.
See: emberjs/guides#2092
Update |filterResults| to |filteredResults| (ember-learn#81)
Changing the variable name as suggested in PR comments.
BradenLawrence
force-pushed
the
yield-edit
branch
from
8aeda93
to
d52fd77
Compare
|
Thanks for the PR! 👍 |
chancancode
pushed a commit
that referenced
this pull request
Oct 25, 2019
* Added markdown linting * Linted and corrected existing content * Fixed package.json error * Word mismatched with guides-source dictionary * Setup linting to run on each build * Also, fixed issue with the `[TODO: ...]` undefined references. Co-authored-by: maxwondercorn <gmartell@pobox.com> --- Commit: ember-learn/super-rentals-tutorial@323d211 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/323d211393666035c4e73a81c7a06b3e3d75c974/scripts/deploy.sh Logs: https://travis-ci.org/ember-learn/super-rentals-tutorial/jobs/603059208
chancancode
pushed a commit
that referenced
this pull request
Oct 25, 2019
* Added markdown linting * Linted and corrected existing content * Fixed package.json error * Word mismatched with guides-source dictionary * Setup linting to run on each build * Also, fixed issue with the `[TODO: ...]` undefined references. Co-authored-by: maxwondercorn <gmartell@pobox.com> --- Commit: ember-learn/super-rentals-tutorial@323d211 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/323d211393666035c4e73a81c7a06b3e3d75c974/scripts/deploy.sh Logs: https://travis-ci.org/ember-learn/super-rentals-tutorial/jobs/603059208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will align super-rentals to changes made in the guides.
|rentals| is changed to |filterResults| to make its connection
to {{yield results}} more explicit.
See: emberjs/guides#2092