Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'firstObject/lastObject' properties in Ember 4 with native proxies #1726

Merged
merged 2 commits into from Feb 16, 2023
Merged

Fix 'firstObject/lastObject' properties in Ember 4 with native proxies #1726

merged 2 commits into from Feb 16, 2023

Commits on Feb 16, 2023

  1. Added test cases to reproduce the 'firstObject' issue

    @hjdivad
    Larry Yu authored and hjdivad committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    b048dc6 View commit details
    Browse the repository at this point in the history

  2. Implement firstObject, lastObject 

    Rather than rely on the implementations from `MutableArray`, implement
these utility methods directly for the native proxy.
    @hjdivad
    Larry Yu authored and hjdivad committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    85e9505 View commit details
    Browse the repository at this point in the history