Properly re-export types #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/fix-type-reexport
branch
from
65c4ddb
to
6b37e56
Compare
|
Any chance to get this reviewed/merged, would be nice to clean up the build output of our app a bit :) |
|
Maybe @chriskrycho could help land this one and another small fix #123? |
|
I'll take a look at these on Monday! |
chriskrycho
approved these changes
Jan 8, 2022
|
(Will merge when CI is ✅) |
|
Released in v3.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves type-only modules to be
.d.tsinstead of.tsand usesexport typeto re-export them, avoiding warnings in Embroider.Closes #128