Use content-tag, which fixes *all the bugs*

[NullVoxPopuli]

Learned some new cli-fu today:

❯ git diff --shortstat HEAD~1 -- . ':(exclude)yarn.lock' 
 33 files changed, 41 insertions(+), 2367 deletions(-)

the actual diff!

Breaking changes

all consumers that were importing from ember-template-imports will no longer be able to.
folks should typically want to use content-tag instead of ember-template-imports after this change.

Blockers

• Ensure that plugin-transform-class-static-block is provided emberjs/ember-cli-babel#502
• BUG: backticks are not escaped embroider-build/content-tag#24

---

Extra bonus -- most of the code from the original implementation is gone now 🎉 yay deleting code!

(most of the additions are lockfile, btw)
((also most of the removals, but also 98% of the old code is gone, too))

This is a breaking change, however:

• no more hbs support
• all downstream dependencies importing from ember-template-imports will need to not import from ember-template-imports.

Related,

• uses https://github.com/emberjs/babel-plugin-ember-template-compilation/, which also has min ember version of 3.27
• uses https://github.com/embroider-build/content-tag/ for the actual parsing
• removes unused dependencies
  • which also had me remove unused type declarations packages
  • which also had me remove unused type declaration files
• removes every file that would no longer be used
  • this means tsc is no longer needed, so I removed that from the package.json scripts
• removes every reference to build and jest

Not related,

• I disabled the lint node/no-missing-require -- because it's buggy. and eslint-plugin-node hasn't been maintained for quite some time -- long term solution here is to switch to esilnt-plugin-n
• I also disabled the lint node/no-unpublished-require -- because it doesn't understand how peer dependencies work.

resolved issues encountered while working on this PR

What I need help with,

• why did I need to add @babel/plugin-transform-class-static-block? browsers support this (I got a babel error about needing to add this)
  • RESOLUTION: per use content-tag #182, I need to make the babel plugins peers -- it's intended that the plugins are needed due to the decorator transform our community is using.
• looks like the test suite was maybe never passing against ember v5? -- it may take me a bit to figure out what's going on there
  UPDATE: I have things working on stackblitz -- so I don't yet know what's going on with C.I.:
  

Supersedes #182

[NullVoxPopuli]

Failures exist over here: #190, so it has nothing to do with content-tag

[chriskrycho]

What does this mean?

all downstream dependencies importing from ember-template-imports will need to not import from ember-template-imports.

[NullVoxPopuli]

all downstream dependencies importing from ember-template-imports will need to not import from ember-template-imports.

What does this mean?

eslint-plugin-ember and ember-template-lint will need to remove their (peer)dependencies on ember-template-imports, because the util and GLIMMER_TEMPLATE constant have been removed.

prettier-plugin-ember-template-tag should be fine because it declares its own hard dependency on ember-template-imports.

There are paths forward for each of these, and @patricklx has been doing awesome work making legit lint tooling and I don't know what or if there is a story for combining efforts with content-tag, but the benefits, impact, and desire for getting the tools off of ember-template-imports is described here: #143

[NullVoxPopuli]

There's a bit of bitrot, so I'm going to open some other PRs to try to make this easier.

• ember-cli-babel v8 is needed
• ember-cli-htmlbars needs upgraded
• ember-qunit needs upgraded (to not use ember-cli-typescript)
  (this'll require some other upgrades as well, like ember-cli)

My hope is that I can avoid waiting for typed-ember/ember-cli-typescript#1569 as well, but timing might work out where it's no big deal.

[NullVoxPopuli]

Running in to:

Error: Could not find module `ember-compatibility-helpers` imported from `@glimmer/component/index`
                at missingModule (http://localhost:7357/assets/vendor.js:266:11)
                at findModule (http://localhost:7357/assets/vendor.js:277:7)
                at Module.findDeps (http://localhost:7357/assets/vendor.js:187:24)
                at findModule (http://localhost:7357/assets/vendor.js:281:11)
                at Module.findDeps (http://localhost:7357/assets/vendor.js:187:24)

I remember ember-compatibility-helpers having issues throughout the years.

The modern way do to what it wants to do is embroider/macros.
which.. would require a bunch more changes to other packages -- so hoping that's not needed

[NullVoxPopuli]

update: by switching to pnpm,

• patches arent needed
• we dont need to release the other two packages
• everything works

---

old comment:

We need to merge / release:

• add ember-cli-babel 8 to version check ember-cli/ember-compatibility-helpers#57
• and Loosen version check against ember-cli-babel typed-ember/ember-cli-typescript#1569 (tho, I've had a really hard time getting this repo green, which is a smidge frustrating)

Gonna switch this project to pnpm in another PR tho, because yarn can't handle the state of our dependencies right now (locally, I have tests passing, but in yarn, I have the above ember-compatibility-helpers issue, which is typically due to incorrect duplicate dependencies in the dep graph)

[NullVoxPopuli]

this PR now builds on top of: #203
so the diff here will be huge until #203 is merged

[patricklx]

It says it fixes all the bugs. But didn't close any GitHub issues :)

[NullVoxPopuli]

Oops. Thanks!