Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 'quotes' rule for 3.0 #1712

Closed
MelSumner opened this issue Jan 26, 2021 · 2 comments
Closed

update 'quotes' rule for 3.0 #1712

MelSumner opened this issue Jan 26, 2021 · 2 comments
Labels
Milestone

Comments

@MelSumner
Copy link
Contributor

For 'next' branch:

Now that .html files are included, the quotes rule (you must use double quotes in templates) is throwing a false positive over acceptable lines.

Example:

{{content-for 'head'}}
{{content-for 'head-footer'}}

These should be allowed.

@MelSumner MelSumner added the bug label Jan 26, 2021
@MelSumner MelSumner added this to the 3.0.0 milestone Jan 26, 2021
@rwjblue
Copy link
Member

rwjblue commented Jan 26, 2021

Hmm, I don't think we should allow those arbitrarily. Applications are manually opting in to "stylistic" configuration, which requires double quotes (Note: it is not in default recommended set).

I also think it would be perfectly fine to update the ember-cli blueprint to use double quotes in the blueprint (to reduce the manual changes needed for new projects that want to use stylistic config).

@MelSumner
Copy link
Contributor Author

ok, I'll close this as not a bug then. Thank you for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants