Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various no-unknown-arguments-for-builtin-components errors #1820

Closed
sebastianhelbig opened this issue Mar 6, 2021 · 4 comments
Closed

various no-unknown-arguments-for-builtin-components errors #1820

sebastianhelbig opened this issue Mar 6, 2021 · 4 comments

Comments

@sebastianhelbig
Copy link

sebastianhelbig commented Mar 6, 2021

  1. All this arguments are working as expected. Imho it should not show any error. Or did I miss something?
  2. @invokeAction is added to LinkTo by https://github.com/Kuzirashi/ember-link-action. What should be done to support this?

Input

error  "@autocomplete" is unknown argument for <Input /> component. Did you mean "@value"?  no-unknown-arguments-for-builtin-components
error  "@class" is unknown argument for <Input /> component. Did you mean "@escape-press"?  no-unknown-arguments-for-builtin-components
error  "@required" is unknown argument for <Input /> component. Did you mean "@escape-press"?  no-unknown-arguments-for-builtin-components
error  "@spellcheck" is unknown argument for <Input /> component. Did you mean "@checked"?  no-unknown-arguments-for-builtin-components

LinkTo

error  "@class" is unknown argument for <LinkTo /> component. Did you mean "@activeClass"?  no-unknown-arguments-for-builtin-components
error  "@invokeAction" is unknown argument for <LinkTo /> component. Did you mean "@activeClass"?  no-unknown-arguments-for-builtin-components
@rwjblue
Copy link
Member

rwjblue commented Mar 6, 2021

All this arguments are working as expected. Imho it should not show any error. Or did I miss something?

The rule is specifically using the arguments listing detailed in emberjs/rfcs#707. All of the other arguments will be issuing deprecation messages in Ember 3.27 and higher.

@invokeAction is added to LinkTo by https://github.com/Kuzirashi/ember-link-action. What should be done to support this?

Due to the changes proposed in emberjs/rfcs#671 I think that https://github.com/Kuzirashi/ember-link-action should be updated to avoid mutating the built-in LinkTo.


Ultimately, I don't think this is a bug. The rule seems to be working as intended (and is helping you identify issues that you will want to address in your codebase as you progress through newer Ember versions).

@rwjblue
Copy link
Member

rwjblue commented Mar 6, 2021

FWIW, I've also created #1821 to track making these error messages better.

@sebastianhelbig
Copy link
Author

Thanks a lot @rwjblue for the detailed explanation.

@rwjblue
Copy link
Member

rwjblue commented Mar 6, 2021

No problem! You might want to take a look at the new --update-todo feature to let you mark these failures as "todos" (and buy some time to fix them). There are some docs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants