Should we start a Polaris config that folks can opt in to when using gjs/gts?

[NullVoxPopuli]

I think we need to change defaults when using gjs/gts, for example

several rules throw false negatives because templates can reference things imported in JS, but not defined in the template. for example:

import { overInvalidatingClock, clock } from './-resources';

const SomeClocks = <template>
  {{clock}}
  {{overInvalidatingClock}}
</template>;

this throws errors for the following rules:

• no-curly-component-invocation
• no-implicit-this

the behavior of checking if locals are defined or not is handled be eslint / eslint-plugin-ember via transform.

So, for ember-template-lint and a polaris config, I think we should start disabling some rules specifically for gjs/gts files -- and we could use this for the polaris config:

'use strict';

module.exports = {
  extends: 'recommended',
  overrides: [
    {
      files: ['**/*.gjs', '**/*.gts'],
      rules: {
        'no-curly-component-invocation': 'off',
        'no-implicit-this': 'off',
      },
    },
  ],
};

Related: #2786

[bmish]

Do we need a polaris config? Why not just make those overrides part of the recommended config so everyone gets them atuomatically?

[NullVoxPopuli]

yeah, I suppose that makes sense -- this sort of thing can only reduce bugs people face atm: #2844

[bmish]

Just to confirm, it doesn't make any sense to use these rules for these file types, right? If that's right, I think it makes sense to treat this as a bug fix.

And are there likely to be other rules that don't make sense for these file types?

[NullVoxPopuli]

If that's right, I think it makes sense to treat this as a bug fix.

correct, and there is a corresponding eslint-plugin-ember PR for resolving the general collective question of "which locals are not in scope?" (already merged):

• Fix issue with token mapping for lint errors on template tokens in gjs/gts files by displaying eslint error on the opening <template> tag ember-cli/eslint-plugin-ember#1801
• refactor glimmer post-process, better handle template tag ember-cli/eslint-plugin-ember#1795

And are there likely to be other rules that don't make sense for these file types?

potentially! We'll just need to keep iterating I suppose and get more testers