Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested-interactive incorrectly triggering when using role="dialog" #83

Closed
luketheobscure opened this issue Jun 7, 2016 · 3 comments
Closed

Comments

@luketheobscure
Copy link

The following code triggers the nested-interactive rule:

<div role="dialog">
  <button>foo</button>
</div>

This is a common pattern when using modal dialogs.

@nathanhammond
Copy link

For notes:

  1. Any time we have role="dialog" it should probably have a tabindex: <div role="dialog" tabindex="-1">
  2. role="dialog" is allowed to have interactive child elements. Probably worth treating it as inert rather than interactive.

@rwjblue
Copy link
Member

rwjblue commented Jun 7, 2016

/cc @martndemus

@rwjblue
Copy link
Member

rwjblue commented Jun 7, 2016

dialog is listed as part of the standard widget roles (from https://www.w3.org/TR/wai-aria/complete#widget_roles). I can certainly remove dialog from the list of interactive ARIA roles, but I'd really like to have some sort of backup/reasoning on why some of those roles are considered interactive and others aren't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants