Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fixturify-project to v4 #2407

Merged
merged 7 commits into from
Mar 4, 2022
Merged

Update fixturify-project to v4 #2407

merged 7 commits into from
Mar 4, 2022

Conversation

dcyriller
Copy link
Member

Supersedes #2360

When mutating `project.files('.template-lintrc')`, we actually mutate
the object used to give project.files a default value in the Project
class.

With this commit, we create a new project.files instead of mutating
Project.defaultFiles
See previous commit message for more details
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@bmish bmish merged commit 309a1b2 into master Mar 4, 2022
@bmish bmish deleted the upgrade-fixturify branch March 4, 2022 16:08
@bmish
Copy link
Member

bmish commented Mar 4, 2022

Thanks! This should unblock tests needed for #2359 CC: @NullVoxPopuli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants