build(deps): Bump aria-query from 5.1.3 to 5.3.0 #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/aria-query-5.3.0
branch
from
2c1dfdb
to
a0fd5fa
Compare
Bumps [aria-query](https://github.com/A11yance/aria-query) from 5.1.3 to 5.3.0. - [Changelog](https://github.com/A11yance/aria-query/blob/main/CHANGELOG.md) - [Commits](A11yance/aria-query@v5.1.3...v5.3.0) --- updated-dependencies: - dependency-name: aria-query dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/aria-query-5.3.0
branch
from
a0fd5fa
to
bf06838
Compare
HeroicEric
added a commit
to HeroicEric/ember-template-lint
that referenced
this pull request
Aug 9, 2023
This updates the `require-valid-alt-text` rule so that it does not *require* setting `role="presentation"` or `role="none"` for an `<img alt="" />`. Context After bumping `aria-query` in ember-template-lint#2927, `ember-template-lint` began reporting an error for the following: ```html <img alt="" role="presentation" /> ``` The error is from the `no-redundant-role`. I believe it is correct to report an error in this case because `<img alt="" />` already implicitly has a `role` of `presentation`. However, this new behavior was in direct conflict with part of the `require-valid-alt-text` rule that required setting `role="presentation"` or `role="none"` whenever an image has `alt=""`.
HeroicEric
added a commit
to HeroicEric/ember-template-lint
that referenced
this pull request
Aug 9, 2023
Fixes ember-template-lint#2951 This updates the `require-valid-alt-text` rule so that it does not *require* setting `role="presentation"` or `role="none"` for an `<img alt="" />`. Context After bumping `aria-query` in ember-template-lint#2927, `ember-template-lint` began reporting an error for the following: ```html <img alt="" role="presentation" /> ``` The error is from the `no-redundant-role`. I believe it is correct to report an error in this case because `<img alt="" />` already implicitly has a `role` of `presentation`. However, this new behavior was in direct conflict with part of the `require-valid-alt-text` rule that required setting `role="presentation"` or `role="none"` whenever an image has `alt=""`.
HeroicEric
added a commit
to HeroicEric/ember-template-lint
that referenced
this pull request
Aug 9, 2023
Fixes ember-template-lint#2951 This updates the `require-valid-alt-text` rule so that it does not *require* setting `role="presentation"` or `role="none"` for an `<img alt="" />`. Context After bumping `aria-query` in ember-template-lint#2927, `ember-template-lint` began reporting an error for the following: ```html <img alt="" role="presentation" /> ``` The error is from the `no-redundant-role`. I believe it is correct to report an error in this case because `<img alt="" />` already implicitly has a `role` of `presentation`. However, this new behavior was in direct conflict with part of the `require-valid-alt-text` rule that required setting `role="presentation"` or `role="none"` whenever an image has `alt=""`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps aria-query from 5.1.3 to 5.3.0.
Changelog
Sourced from aria-query's changelog.
Commits
fff6f075.3.002e427cUpdate CHANGELOG for v5.3.0fda2c97fix: amend breaking changes and reinstate constraints (#515)f9f9ea6Add prepublishOnly step to package.json (#506)d7e68dd5.2.1bf8b0caUpdate CHANGELOG for v5.2.1c995082Run npm i to update package-lock.jsonef150a35.2.0413365fUpdating Changelog to include v5.2.0 (#501)e2e3effdocs: update README to WAI-ARIA 1.2 spec (#499)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)