Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support indents and folding #134

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

NullVoxPopuli
Copy link
Member

@NullVoxPopuli NullVoxPopuli commented Mar 16, 2024

Copies over the contents from the original PR here: #112

Sorry, @yads, idk what happened. Is this missing anything?

Folding

image

image

image

image

Locals

how do you verify that this does anything?

Indents

Screencast.from.2024-03-16.14-27-43.webm

Copies over the contents from the original PR here: #112
@yads
Copy link

yads commented Mar 19, 2024

So the only thing is for locals, this is what's already in the nvim-treesitter repo https://github.com/nvim-treesitter/nvim-treesitter/blob/master/queries/glimmer/locals.scm

@NullVoxPopuli
Copy link
Member Author

ah ok, so locals is already upstream. hmm.

where are the queries supposed to live? are the meant to be duplicated to nvim-treesitter?

@yads
Copy link

yads commented Mar 19, 2024

These queries are all upstream. I think you want them to live in both places. Although I feel like the nvim-treesitter team wants to remove all the queries that live in that project and use the queries in subprojects like this one.

@NullVoxPopuli
Copy link
Member Author

Sounds good to me! 🎉

@NullVoxPopuli NullVoxPopuli merged commit 6b25d26 into main Mar 19, 2024
6 checks passed
@NullVoxPopuli NullVoxPopuli deleted the support-indents-and-folding branch March 19, 2024 22:09
@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants