Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel-import-util and use it to manage babel bindings more precisely #42

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Apr 26, 2024

This switches most of our usage to the new automatic-reference APIs in babel-import-util.

The only remaining place where we're responsible for managing the references ourselves is ones introduced by jsutils.bindImport. But we're already responsible for managing references to everything in the scope bag anyway, so that is appropriate.

This refactors the scope-bag-reference management so it happens more precisely, directly against the scope bag (in 'hbs' target mode) or the locals array (in 'wire' target mode). This should result in a slightly more efficient plugin, since we're recrawling a small set of the AST to establish references.

@ef4 ef4 added the internal label Apr 26, 2024
@ef4 ef4 merged commit 36751f6 into main Apr 26, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the scope-precision branch April 26, 2024 15:53
@github-actions github-actions bot mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant