Remove extraneous import from @ember/template-compiler

[NullVoxPopuli]

First commit:

demonstrates a failing test where @ember/template-compiler is left in the output code.
This manifests itself in the default blueprint when two components exist in the same file:

reproduction is simple

Input code:

import Component from '@glimmer/component';

export default class Test extends Component {
  foo = 1;

  <template><Icon /></template>
}

const Icon = <template>Icon</template>;

Which is intermediately (still correct):

import { template } from "@ember/template-compiler";
import Component from '@glimmer/component';
export default class Test extends Component {
    foo = 1;
    static{
        template("<Icon />", {
            component: this,
            eval () {
                return eval(arguments[0]);
            }
        });
    }
}
const Icon = template("Icon", {
    eval () {
        return eval(arguments[0]);
    }
});

Output code:

import '@ember/template-compiler';
import Component from '@glimmer/component';
import { precompileTemplate } from '@ember/template-compilation';
import { setComponentTemplate } from '@ember/component';
import templateOnly from '@ember/component/template-only';

class Test extends Component {
  foo = 1;
  static {
    setComponentTemplate(precompileTemplate("<Icon />", {
      strictMode: true,
      scope: () => ({
        Icon
      })
    }), this);
  }
}
const Icon = setComponentTemplate(precompileTemplate("Icon", {
  strictMode: true
}), templateOnly());

export { Test as default };
//# sourceMappingURL=test.js.map

Rollup detects that { template } is unused, but then leaves a side-effecting import for @ember/template-compiler

[ef4]

Ah, so the previous release just cleaned up all our need for scope.crawl. It appears that this one place was not covered.

The fix for this will go into babel-import-util. Using util.removeImport is supposed to correct the scope references.

[ef4]

Looking closer I didn't explain correctly in my comment above, but the basic point is still true: we don't need scope.crawl when we're the ones directly responsible for removing the reference. We should be updating the scope at that point so it stays correct.

[ef4]

Thanks, the test was helpful in narrowing this down.