Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename docs-team folder to learning-team #264

Closed
mansona opened this issue Feb 15, 2019 · 7 comments
Closed

rename docs-team folder to learning-team #264

mansona opened this issue Feb 15, 2019 · 7 comments
Assignees

Comments

@mansona
Copy link
Member

mansona commented Feb 15, 2019

Howdy folks 馃憢

We have recently documented our process for getting the Learning team core-notes into this repo and today is the first time that I have come to add minutes (it's my turn) 馃帀

I noticed that there is no learning-team folder and that our learning team minutes are instead in the docs-team folder. I don't fully understand the history of the learning team since I'm new, but I was under the impression that we very purposely don't call it a docs-team for various reasons that are probably spread over many videos on YouTube and blogs.

Is there any objection to renaming the folder from docs-team to learning-team?

@acorncom
Copy link
Contributor

The context here is that the folder was named before the learning team became the learning team 馃槈 I have no objection in concept (it would be more consistent) but we鈥檇 also lose history in the process of the move. @locks can you explain your reaction here?

@mansona
Copy link
Member Author

mansona commented Feb 15, 2019

@acorncom what would you mean by "los[ing] history" in this case? if we do it as a normal git move then the history will be maintained from a file perspective.

If we want to represent the fact that the docs team "evolved" into the learning team we should probably only move files after the date it was made official.

I just think it's odd that I'm adding something to the docs-team folder. I am not a member of the docs team, I'm a member of the learning team 馃槀 and it matters what you name things 馃憤

@locks
Copy link
Collaborator

locks commented Feb 15, 2019

My objection is a recurring one, I am not keen on breaking URLs for what I perceive to be little gain in this instance.

@rwjblue
Copy link
Member

rwjblue commented Feb 15, 2019

I agree, many of these notes have been cross linked (in various comments, blog posts, etc). I think it would be totally great to start using the correct terminology going forward, and we could even copy the contents into the correct place, but we shouldn't remove it from docs-team.

I think my concrete suggestion would be:

  • Add a top level learning-team folder
  • Start adding new content to learning-team
  • Add a docs-team/README.md explaining that the folder is legacy and new items are added in learning-team.
  • Optionally fail CI if a new file is added to docs-team (helps us to not forget 馃槢)
  • Optionally copy all existing docs-team content into the new folder

What say y'all?

@rwjblue
Copy link
Member

rwjblue commented Feb 15, 2019

Also, FWIW, learning-team was coined back in May of 2016, so at least some of the content here predates the newer term.

https://emberjs.com/blog/2016/05/19/introducing-subteams.html

We should decide if the content in the learning-team folder is just content after that date, or if it was "retroactive".

@amyrlam
Copy link
Member

amyrlam commented Apr 13, 2019

Made this PR, please leave feedback, can make changes to get this closed! #273

@amyrlam
Copy link
Member

amyrlam commented Apr 18, 2019

Closed via #273

@amyrlam amyrlam closed this as completed Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants