[BUGFIX docs] ensure we publish docs (#6257)

emberjs · Jul 18, 2019 · 62ac658 · 62ac658
1 parent a80f2d0
commit 62ac658
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 3 deletions.
diff --git a/bin/publish.js b/bin/publish.js
@@ -260,6 +260,25 @@ function packAllPackages() {
     const pkgInfo = require(pkgPath);
     if (pkgInfo.private !== true) {
       // will pack into the project root directory
+      // due to an issue where npm does not run prepublishOnly for pack, we run it here
+      // however this is also a timing bug, as typically it would be run *after* prepublish
+      // and prepare and now it is run *before*
+      // we do not use `prepublish` or `prepare` so this should be fine for now.
+      // https://docs.npmjs.com/misc/scripts
+      // https://github.com/npm/npm/issues/15363
+      if (pkgInfo.scripts) {
+        if (pkgInfo.scripts.prepublishOnly) {
+          if (pkgInfo.scripts.prepublish || pkgInfo.scripts.prepare) {
+            console.log(
+              `⚠️ ` +
+                chalk.grey(
+                  `${pkgInfo.name} has both a 'prepublishOnly' and either 'prepare' or 'publish' scripts. Running prepublishOnly manually before instead of after publish and prepare. See https://github.com/npm/npm/issues/15363`
+                )
+            );
+          }
+          execWithLog(`cd ${pkgDir} && npm run prepublishOnly`);
+        }
+      }
       execWithLog(`npm pack ${pkgDir}`);
     }
   });

diff --git a/packages/-ember-data/.npmignore b/packages/-ember-data/.npmignore
@@ -1,5 +1,6 @@
 # compiled output
 /dist/
+/dist/**/*
 /tmp/
 /types/
 **/*.d.ts

diff --git a/packages/adapter/.npmignore b/packages/adapter/.npmignore
@@ -1,5 +1,6 @@
 # compiled output
 /dist/
+/dist/**/*
 /tmp/
 /types/
 **/*.d.ts
@@ -33,4 +34,7 @@
 /package.json.ember-try
 
 # ember-data
-/node-tests
+/node-tests
+
+# whitelist yuidoc's data.json for api docs generation
+!/dist/docs/data.json
diff --git a/packages/model/.npmignore b/packages/model/.npmignore
@@ -1,5 +1,6 @@
 # compiled output
 /dist/
+/dist/**/*
 /tmp/
 /types/
 **/*.d.ts
@@ -33,4 +34,7 @@
 /package.json.ember-try
 
 # ember-data
-/node-tests
+/node-tests
+
+# whitelist yuidoc's data.json for api docs generation
+!/dist/docs/data.json
diff --git a/packages/serializer/.npmignore b/packages/serializer/.npmignore
@@ -1,5 +1,6 @@
 # compiled output
 /dist/
+/dist/**/*
 /tmp/
 /types/
 **/*.d.ts
@@ -33,4 +34,7 @@
 /package.json.ember-try
 
 # ember-data
-/node-tests
+/node-tests
+
+# whitelist yuidoc's data.json for api docs generation
+!/dist/docs/data.json
diff --git a/packages/store/.npmignore b/packages/store/.npmignore
@@ -1,5 +1,6 @@
 # compiled output
 /dist/
+/dist/**/*
 /tmp/
 /types/
 **/*.d.ts
@@ -31,3 +32,6 @@
 /.node_modules.ember-try/
 /bower.json.ember-try
 /package.json.ember-try
+
+# whitelist yuidoc's data.json for api docs generation
+!/dist/docs/data.json