[BUGFIX canary] eliminate recordData prop restriction

emberjs · Mar 24, 2019 · 739f78e · 739f78e
1 parent aed597c
commit 739f78e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 18 deletions.
diff --git a/addon/-private/system/model/model.js b/addon/-private/system/model/model.js
@@ -1213,16 +1213,6 @@ if (DEBUG) {
         );
       }
 
-      if (
-        !isDefaultEmptyDescriptor(this, 'recordData') ||
-        this.recordData !== undefined ||
-        this.recordData !== this._internalModel.recordData
-      ) {
-        throw new Error(
-          `'recordData' is a reserved property name on instances of classes extending Model. Please choose a different property name for ${this.constructor.toString()}`
-        );
-      }
-
       if (
         !isDefaultEmptyDescriptor(this, 'currentState') ||
         this.get('currentState') !== this._internalModel.currentState

diff --git a/tests/unit/model-test.js b/tests/unit/model-test.js
@@ -676,12 +676,6 @@ module('unit/model - Model', function(hooks) {
       @attr('string')
       name;
     }
-    class NativePostWithRecordData extends Model {
-      @attr('string', { defaultValue: 'hello' })
-      recordData;
-      @attr('string')
-      name;
-    }
     class NativePostWithCurrentState extends Model {
       @attr('string')
       currentState;
@@ -690,7 +684,6 @@ module('unit/model - Model', function(hooks) {
     }
     const PROP_MAP = {
       _internalModel: NativePostWithInternalModel,
-      recordData: NativePostWithRecordData,
       currentState: NativePostWithCurrentState,
     };
 
@@ -730,7 +723,7 @@ module('unit/model - Model', function(hooks) {
       });
     }
 
-    ['recordData', '_internalModel', 'currentState'].forEach(testReservedProperty);
+    ['_internalModel', 'currentState'].forEach(testReservedProperty);
 
     testInDebug(
       'A subclass of Model throws an error when calling create() directly',