Meta Relationships Issue

[wycats]

A number of issues with relationships will be resolved with an upcoming refactor of relationships.

I'm tracking them here so I remember to keep them in mind and avoid exploding the ticket count with issues that will all be resolved at once.

• Bidirectional relation sync (Regression with bidirectional relation sync #1302, Fix failing relationship updates with other errors #1330)
• Inverse clearing (clearRelationship not clearing inverses. #1303)
• Dirtying when belongsTo changes (When belongsTo change, record does not set dirty. #1367)

[alexspeller]

I was also experiencing this issue - it seems that it occurs with both async and non-async relationships.

[matthooks]

+1 for the bidirectional relationship sync issue on non-async hasMany relationships.

[alexspeller]

@wycats what's the timeline on this refactor? Having the relationships live update is pretty important to my use case and I'd be willing to try and fix this without relying on a massive refactor unless the timeline is very soon - would you be willing to merge a temp fix for this issue pending the big refactor?

[wycats]

I would give the refactor a week (or two, tops). I'd be happy to merge a short-term fix that wasn't too invasive.

[decasia]

+1 to this issue in general. I think it also would really help to have more docs on how async relationships are supposed to work; I'm seeing foreign keys inexplicably getting set to null on save, which may well be an error on my part somewhere, but without clear docs about what I should be doing, it's hard for me to sort out. Not sure if that has anything to do with this commit.

[wycats]

Failing test in #1327.

[epotvin]

About the issue #1302, the problem is not resolved. Check this example :

http://jsfiddle.net/NQKvy/235/

Clicking the button execute the test action of IndexController. The action creates a new mail with the discussion set to the current discussion. So the relation "discussion" of the object "mail" has the good value. But in the "mails" attribute of the "Discussion" object, the new mail is not there, meaning that the bidirectional relation is broken.

The mail not being in the mails relation of the discussion avoid it to be displayed under the already saved mail with text Hello.

Emmanuel

[tim-evans]

This issue is leaving our app in a bit of a borked state. I've been very satisfied with the upgrade to 1.0 otherwise. Really solid work.

[bradleypriest]

Another to possibly add to the list, although it is a little specific to embedded objects.

The _data attribute isn't reset after commit for objects apart from the primary object because it is triggered by adapterDidCommit. Inversely, inFlightAttributes aren't set on save.

[JaredSartin]

status?

[alexspeller]

@JaredSartin nothing has changed otherwise the issue would be updated

[JaredSartin]

Sorry, @alexspeller. I am trying to keep vital issues on the periphery and was hoping that progress was made without an update. @wycats said a week or 2 tops... In any manner, is there a decent workaround?

[lukegalea]

Any updates on this? Not having relationships set isDirty is a huge problem for us as we want to alert the user that there are unsaved changes.

[decasia]

@lukegalea, for what it's worth, it's possible to implement that functionality yourself fairly easily -- here's a gist of some code that works for me. Hopefully I can get rid of this code later when Ember implements the feature, but for now the workaround has been adequate.

[lukegalea]

Thanks. I have something similar working now, but I sure would love some
native support in Ember-Data :)

On Wed, Jan 29, 2014 at 2:37 PM, eli thorkelson notifications@github.comwrote:

@lukegalea https://github.com/lukegalea, for what it's worth, it's
possible to implement that functionality yourself fairly easily -- here's a
gist of some code that works for mehttps://gist.github.com/decasia/8695244.
Hopefully I can get rid of this code later when Ember implements the
feature, but for now the workaround has been adequate.

Reply to this email directly or view it on GitHubhttps://github.com//issues/1308#issuecomment-33621408
.

Luke Galea
CTO | PrecisionNutrition

[kumavis]

+1 #1367 Dirtying when belongsTo changes

[kumavis]

Additionally, the ability to rollback those relations

[timrwood]

I've opened an RFC for this issue. Please weigh in.

emberjs/rfcs#21

[sly7-7]

I'm closing, superceeded by #2545