store.createRecord + record.save do not resolve hasMany-Relationships

[sandreas]

I tried to use store.createRecord for persisting hasMany-relationships, but they are not resolved in store.createRecord (store.push works correctly).

Here is a sample. Beware: There is no open REST api on jsbin, so requests are just "simulated". Open Firebug network protocol and look at "request payload":
http://jsbin.com/OJOJoFE/1/edit?html,js,output

Example code snippet:

App.Role = DS.Model.extend({
    name: DS.attr('string')
});
App.User = DS.Model.extend({
    username: DS.attr('string'),
    password: DS.attr('string'),
    roles: DS.hasMany('role')
});

    var model = {
      username: 'username',
      password: 'password',
      roles: [1,2]
    };

// create a record based on model data
record = this.get('store').createRecord('user', model);

// persist created record to REST 
// should send: username='username', password='password' and roles=[1,2]
// actually sends: username='username', password='password' and roles=[]
record.save();

[endash]

Based on the jsbin and talking on IRC I would say not a bug. The list of properties passed to createRecord eventually gets passed to setProperties, and is a bit of a shortcut, thus it uses the hasMany setter, which doesn't do anything with the passed value, instead looking up ids from the data hash. push is how you would load raw data that you want to be transformed into relationships.

[sandreas]

Well, i still would call this a bug (at least an important enhancement), because behavior is not consistent here... there is no way to create a record with relationships, without manually passing all the relationship-properties in...

// UserCreateController
actions: {
    saveFormValues: function (formValues) {
        var record = this.store.createRecord('user', formValues);
        // i think this is redundant here, if the roles are selected via the form, createRecord should take these as reference
        record.get('roles').addObjects(formValues.roles);
    }
}

[FeipingHunag]

App.ApplicationSerializer = DS.ActiveModelSerializer.extend
  serializeHasMany: (record, json, relationship) ->
    key = relationship.key
    kind = relationship.kind
    relationshipType = DS.RelationshipChange.determineRelationshipType(record.constructor, relationship)
    if relationshipType is 'manyToNone' or relationshipType is 'manyToMany'
      json[@keyForRelationship(key, kind)] = record.get(key).mapBy('id')

[igorT]

@FeipingHunag The problem here is not that the ids are not being serialized, but rather that createRecord doesn't accept relationships. I wouldn't expect it to accept ids in either case, but I feel like it should be possible to do

    var role1 = this.get('store').createRecord('role');
    var role2 = this.get('store').createRecord('role')

    var model = {
      username: 'username',
      password: 'password',
      roles: [role1, role2] 
    };

// create a record based on model data
record = this.get('store').createRecord('user', model);

[sly7-7]

@sandreas @igorT I assume this is fixed since ssot merge, isn't it ?

[igorT]

Not sure, let me test

[igorT]

Hasn't been fixed yet, but should be simple. We just need to make https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/store.js#L271 smarter @sly7-7 have time to try?