Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Map/MapWithDefault/Set polyfills after beta.12 is released #2512

Closed
fivetanley opened this issue Nov 25, 2014 · 7 comments
Closed

Remove Map/MapWithDefault/Set polyfills after beta.12 is released #2512

fivetanley opened this issue Nov 25, 2014 · 7 comments
Assignees

Comments

@fivetanley
Copy link
Member

No description provided.

@igorT
Copy link
Member

igorT commented May 25, 2015

Ping

@sly7-7
Copy link
Contributor

sly7-7 commented Jun 3, 2015

Seems like there is no more polyfill for map, since the map file is basically empty: https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/map.js

Also @wecc, you were overriding some behavior for Ember.OrderedSet (not preserving the right order ?)

So I'm a bit confused of what to do exactly for this issue

@sly7-7
Copy link
Contributor

sly7-7 commented Jun 5, 2015

@wecc @fivetanley ping ?

@wecc
Copy link
Contributor

wecc commented Jun 5, 2015

I don't think we can remove our changes in Ember.OrderedSet as they are not upstreamed.

@sly7-7
Copy link
Contributor

sly7-7 commented Jun 5, 2015

Ok, so that means this issue could be closed ?

@wecc
Copy link
Contributor

wecc commented Jun 5, 2015

We might still want to remove the other ones?

@sly7-7
Copy link
Contributor

sly7-7 commented Jun 5, 2015

Ok, so I guess it's basically removing this file and replace its use by import from Ember the Map and MapWithDefault ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants