remove Map/MapWithDefault polyfills, use Ember's ones

[sly7-7]

Closes #2512

[fivetanley]

Need to make sure with @stefanpenner these aren't likely to change.

[sly7-7]

@fivetanley @stefanpenner any news on that ?

[stefanpenner]

@fivetanley is ED relying on the public API's of Map/MapWithDefault?

I just realized, for some reason all its API's are marked as private... I believe this is a mistake

[stefanpenner]

I suspect as long as,

• size
• set
• get
• forEach
• delete
• has
• clear

are the only methods used, everything should be fine.

[sly7-7]

@stefanpenner Thanks for the investigation 👍

As a side note, is it safe to use Ember.Map/MapWithDefault in client app ?

[stefanpenner]

As a side note, is it safe to use Ember.Map/MapWithDefault in client app ?
Show all checks

I would say so, but I didn't release they are marked as private. Someone should investigate :P

[sly7-7]

@stefanpenner It seems like Map has been marked private since the beggining, at least since the first move to yuidoc, see: emberjs/ember.js@1325935#diff-7d75f034e93c4304edfd8944392ef2e0R60

Also, here @rwjblue took that in account to mark all the method as private, but it seems like there is no pb to make them public if wanted/needed

[sly7-7]

@fivetanley ping ?

[wecc]

@sly7-7 I think this would be great to get merged, would you be able to sort out the conflicts?

[sly7-7]

@wecc My pleasure, Should be ok now 😄

[bmac]

Thanks @sly7-7.