Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No model update from PUT request result in beta.15 #2900

Closed
plcarmel opened this issue Mar 19, 2015 · 10 comments
Closed

No model update from PUT request result in beta.15 #2900

plcarmel opened this issue Mar 19, 2015 · 10 comments

Comments

@plcarmel
Copy link

ember-data 1.0.0-beta.15 is not updating the model from the result of a PUT request anymore.

I downgraded ember-data to 1.0.0-beta.14 and the bug is not present in this version.

@seanpdoyle
Copy link
Contributor

Could you distill an example demonstrating this behavior into a JSbin?

@plcarmel
Copy link
Author

I am very short on time but I will try.

@bmac
Copy link
Member

bmac commented Mar 26, 2015

Hi @plcarmel, Did you have any luck tracking down this issue? I attempted to put together a jsbin based on what you described but I was unable to reproduce the issue. http://emberjs.jsbin.com/xutihotapi/1/edit?html,js

@plcarmel
Copy link
Author

plcarmel commented Apr 9, 2015

Hi @bmac. Sorry for the delay. No, I did not have any luck yet. I checked your jsbin and I saw it is working fine. So I upgraded my code again to beta.15 just to make sure I could still reproce the problem and I still can. I will have some slack next week and I am going to investigate the problem.

@plcarmel
Copy link
Author

plcarmel commented Apr 9, 2015

Problem is still present in beta.16.1

@plcarmel
Copy link
Author

Ok, I toyed with the jsbin and I finally got something.

http://emberjs.jsbin.com/texixi/1/edit

Press the "save" button. It is going to work fine. Now change the value in the textbox. Press the "save" button again. It is not going to work; the value will stay the same.

Switch to the beta.14 ember-data file (see commented out line) and do the same sequence. Now, it is going to work every time.

@bmac
Copy link
Member

bmac commented Jun 5, 2015

I just tried out the above jsbin using the latest master build and this issue appears to have been fixed. http://emberjs.jsbin.com/wiveqejive/1/edit?html,css,js

@bmac bmac closed this as completed Jun 5, 2015
@plcarmel
Copy link
Author

plcarmel commented Jun 5, 2015

I just tried it with the link you provided and it seems the problem is still present. Please follow my instructions carefully. It works for the first save but not for the subsequent ones.

@bmac bmac reopened this Jun 5, 2015
@bmac
Copy link
Member

bmac commented Jun 5, 2015

You are correct. Sorry about that. I'm currently working updating @wecc's pr #2998. Should have a fix for this soon.

@plcarmel
Copy link
Author

plcarmel commented Jun 5, 2015

No worries, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants