Record property changes #3216
Merged
Record property changes #3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| continue; | ||
| } | ||
|
|
||
| if (original[key] !== value) { |
There was a problem hiding this comment.
Can we switch this to use Ember.isEqual while we're at it? http://emberjs.com/api/#method_isEqual
bmac
force-pushed
the
record-property-changes
branch
from
12ae462
to
5022be7
Compare
| _changedKeys: function(updates) { | ||
| var changedKeys = []; | ||
|
|
||
| if (updates && typeof updates === 'object') { |
bmac
force-pushed
the
record-property-changes
branch
from
5022be7
to
cd43c95
Compare
|
@igorT I have updated this pr to address your comments. |
| /** | ||
| @method _changedKeys | ||
|
|
||
| Ember Data has 3 buckets for storing the value of an attribute on an internalModel. |
This was referenced Jun 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased and cleaned version of #2998.
Closes #2937.
Closes #2900.
Closes #2998.