setting the namespace for a model sets the namespace for all models

[NullVoxPopuli]

They should set per model, yeah?

let host = this.get('host');
let hostId = host.get('id');
let hostType = host.get('type');
let parentPath = Ember.String.underscore(hostType);
parentPath = Ember.String.pluralize(parentPath);

let adapter = this.store.adapterFor('packages');

let rootNamespace = adapter.namespace; // api/
let eventDiscountNamespace = rootNamespace + '/' + parentPath + '/' + hostId + '/packages';

adapter.set('namespace', eventDiscountNamespace);

console.log(adapter.namespace);  // api/events/16/packages
console.log(this.store.adapterFor('packages').namespace); // api/events/16/packages

this.store.adapterFor('application').namespace = rootNamespace

console.log(adapter.namespace);  // api/
console.log(this.store.adapterFor('packages').namespace); // api/

as you can see, setting the namespace for packages also sets for the application and then setting for the application sets the packages namespace.

I believe this could result in race conditions issues

[fivetanley]

Can you post your adapter definitions?

[fivetanley]

I think this is pre-existing behavior. If you don't have a packages adapter defined, it will use the existing instance for the application adapter.

[NullVoxPopuli]

oh, ok. so, if I manually define the adapter, then I shouldn't have the above matching console.logs.
I'll try that out tonight.

[NullVoxPopuli]

just tried. same issue. :-(

both adapters have the same namespace. :-(

[pangratz]

Looks like this works, see http://ember-twiddle.com/25804368a1d4ea121ed2. In application/route.js the namespace of the package adapter is overwritten.

@NullVoxPopuli can you reproduce this in another Ember Twiddle or JSBin?

[NullVoxPopuli]

I was using ActiveModelAdapter, I've recently switched to json-api, so I'll give this another go.

[bmac]

@NullVoxPopuli did you get a chance test this issue again?

[NullVoxPopuli]

not yet. been taking a small break from the project. I'll dive in to it again this week though.

[pangratz]

@NullVoxPopuli did you have a chance to check if this is still valid?

[NullVoxPopuli]

I actually migrated everything and have been re-architecting my backend to accomodate a flat-api as having relationship-related namespaces is too difficult.

[pangratz]

Okay, seems good. I am going to close this issue as it couldn't be reproduced. If somebody stumbles upon this and can reproduce, please open a new issue and back-reference this one.