Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastBoot tests breaking on ember-data canary #5186

Closed
kratiahuja opened this issue Sep 23, 2017 · 3 comments
Closed

FastBoot tests breaking on ember-data canary #5186

kratiahuja opened this issue Sep 23, 2017 · 3 comments

Comments

@kratiahuja
Copy link
Contributor

Seems like this PR introduces usage of let which is only allowed in strict mode: https://travis-ci.org/ember-fastboot/ember-cli-fastboot/jobs/279033050 . This is breaking fastboot.

cc: @runspired
@kratiahuja kratiahuja mentioned this issue Sep 23, 2017
Closed
@kellyselden
Copy link
Member

Duplicate of #5177.

@bmac
Copy link
Member

bmac commented Sep 28, 2017

@kratiahuja now that #5176 is merged are the fastboot tests working again or do they still break due to Ember Data?

@kratiahuja
Copy link
Contributor Author

Yes fastboot tests are working again. Thank you. This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmac @kellyselden @kratiahuja