Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing error from Model.errors is not autotracked in ember 3.20.5 #7310

Closed
andreyfel opened this issue Sep 1, 2020 · 7 comments · Fixed by #7331
Closed

Removing error from Model.errors is not autotracked in ember 3.20.5 #7310

andreyfel opened this issue Sep 1, 2020 · 7 comments · Fixed by #7331

Comments

@andreyfel
Copy link
Contributor

Originally I've opened the issue within Ember itself emberjs/ember.js#19097, but the fix was done on the ED side #7273.

It seems that the issue wasn't fixed completely as the errors are not re-rendered when I do model.errors.remove(attr).
See the integration test in the reproduction repo https://github.com/andreyfel/ember-data-errors-autotracking-bug.

@andreyfel
Copy link
Contributor Author

cc: @pzuraq and @igorT who were involved in the first fix.

@igorT
Copy link
Member

igorT commented Sep 1, 2020

Thanks for the report, can you please make a reproduction PR that we can test against, that would be super helpful

@andreyfel
Copy link
Contributor Author

@igorT the test is in the separate repo https://github.com/andreyfel/ember-data-errors-autotracking-bug. Do you want to have it as a PR for ember-data repository?

@igorT
Copy link
Member

igorT commented Sep 1, 2020

That would be great

@andreyfel
Copy link
Contributor Author

Created PR with reproduction #7313

@andreyfel
Copy link
Contributor Author

@snewcomer @igorT thank you for this fix!
Can you guys make a patch release for 3.20.* with this fix?

@igorT
Copy link
Member

igorT commented Sep 24, 2020

@andreyfel I think @snewcomer is planning to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants