Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: errors remove to accurately update in template #7331

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Conversation

snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Sep 20, 2020

the subarray for errorsFor needs to be mutated so observing templates can be notified that the array was updated.

ref #7273
close #7313
close #7310

👋 @andreyfel

@snewcomer snewcomer added the Bug label Sep 20, 2020
@snewcomer snewcomer self-assigned this Sep 20, 2020
@github-actions
Copy link

github-actions bot commented Sep 20, 2020

Performance Report for 61bac86

Relationship Analysis
                        -------------

__/\\\\\\\\\\\\\____/\\\\____________/\\\\____/\\\\\\\\\_____
 _\/\\\/////////\\\_\/\\\\\\________/\\\\\\__/\\\///////\\\___
  _\/\\\_______\/\\\_\/\\\//\\\____/\\\//\\\_\///______\//\\\__
   _\/\\\\\\\\\\\\\/__\/\\\\///\\\/\\\/_\/\\\___________/\\\/___
    _\/\\\/////////____\/\\\__\///\\\/___\/\\\________/\\\//_____
     _\/\\\_____________\/\\\____\///_____\/\\\_____/\\\//________
      _\/\\\_____________\/\\\_____________\/\\\___/\\\/___________
       _\/\\\_____________\/\\\_____________\/\\\__/\\\\\\\\\\\\\\\_
        _\///______________\///______________\///__\///////////////__


                          Runtime Edition

        PM2 is a Production Process Manager for Node.js applications
                     with a built-in Load Balancer.

                Start and Daemonize any application:
                $ pm2 start app.js

                Load Balance 4 instances of api.js:
                $ pm2 start api.js -i 4

                Monitor in production:
                $ pm2 monitor

                Make pm2 auto-boot at server restart:
                $ pm2 startup

                To go further checkout:
                http://pm2.io/


                        -------------

[PM2] Spawning PM2 daemon with pm2_home=/home/runner/.pm2
[PM2] PM2 Successfully daemonized
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name       │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control    │ default     │ N/A     │ fork    │ 3037     │ 0s     │ 0    │ online    │ 0%       │ 26.5mb   │ runner   │ disabled │
└─────┴────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬───────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name          │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼───────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control       │ default     │ N/A     │ fork    │ 3037     │ 0s     │ 0    │ online    │ 0%       │ 71.1mb   │ runner   │ disabled │
│ 1   │ experiment    │ default     │ N/A     │ fork    │ 3075     │ 0s     │ 0    │ online    │ 0%       │ 21.7mb   │ runner   │ disabled │
└─────┴───────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘

===============================================================================
Processing CHANGELOG.md CODE_OF_CONDUCT.md CONTRIBUTING.md README.md RELEASE.md bin lerna.json node_modules package.json packages tmp tsconfig.json yarn.lock
[PM2] [v] Modules Stopped
[PM2] Applying action deleteProcessId on app [all](ids: [ 0, 1 ])
[PM2] [control](0) ✓
[PM2] [experiment](1) ✓
[PM2] [v] All Applications Stopped
[PM2] [v] PM2 Daemon Stopped

@github-actions
Copy link

github-actions bot commented Sep 20, 2020

Asset Size Report for 61bac86

IE11 Builds

EmberData increased by 82.0 B uncompressed but decreased by 9.0 B compressed

Warnings

The uncompressed size of the package @ember-data/model has increased by 82.0 B.

Changeset


EmberData 159.87 KB +82.0 B (34.27 KB -9.0 B compressed)
    @ember-data/model 13.46 KB +82.0 B (2.88 KB -9.0 B compressed)
        @ember-data/model/-private 12.98 KB +82.0 B (2.78 KB -9.0 B compressed)

Full Asset Analysis (IE11)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '159.87 KB' │
│ compressed │ '34.27 KB'  │
│  packages  │      9      │
│  modules   │     46      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '68.79 KB' │
│  compressed  │ '14.75 KB' │
│ % Of Library │   '43.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 67.88 KB  | 14.55 KB   | 98.7          | 42.5
	@ember-data/store/index                           | 936.00 B  | 200.66 B   | 1.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.61 KB' │
│  compressed  │ '4.85 KB'  │
│ % Of Library │   '14.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 22.61 KB  | 4.85 KB    | 100.0         | 14.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.32 KB' │
│  compressed  │ '4.14 KB'  │
│ % Of Library │   '12.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.10 KB   | 1.52 KB    | 36.8          | 4.4
	@ember-data/serializer/-private                   | 5.36 KB   | 1.15 KB    | 27.7          | 3.4
	@ember-data/serializer/json-api                   | 3.71 KB   | 813.80 B   | 19.2          | 2.3
	@ember-data/serializer/rest                       | 2.70 KB   | 593.20 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 243.00 B  | 52.09 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.09 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.77 KB' │
│  compressed  │ '3.17 KB'  │
│ % Of Library │   '9.2'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.80 KB   | 1.67 KB    | 52.8          | 4.9
	@ember-data/adapter/-private                      | 3.54 KB   | 776.71 B   | 24.0          | 2.2
	@ember-data/adapter/error                         | 1.91 KB   | 419.98 B   | 13.0          | 1.2
	@ember-data/adapter/json-api                      | 830.00 B  | 177.94 B   | 5.5           | 0.5
	@ember-data/adapter/index                         | 719.00 B  | 154.14 B   | 4.8           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '13.46 KB' │
│  compressed  │ '2.88 KB'  │
│ % Of Library │   '8.4'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 12.98 KB  | 2.78 KB    | 96.5          | 8.1
	@ember-data/model/index                           | 486.00 B  | 104.19 B   | 3.5           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.28 KB' │
│  compressed  │ '1.99 KB' │
│ % Of Library │   '5.8'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 510.02 B   | 25.0          | 1.5
	ember-data/-private                               | 2.02 KB   | 444.41 B   | 21.8          | 1.3
	ember-data/adapters/errors                        | 1.19 KB   | 260.90 B   | 12.8          | 0.7
	ember-data/setup-container                        | 503.00 B  | 107.83 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 68.17 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.74 B    | 2.9           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 53.81 B    | 2.6           | 0.2
	ember-data/adapters/json-api                      | 245.00 B  | 52.52 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.09 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.09 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 51.66 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.80 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.73 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.45 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.59 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.59 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.73 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 34.73 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.90 KB' │
│  compressed  │ '1.69 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.76 KB   | 605.20 B   | 34.9          | 1.7
	ember-inflector/lib/system/inflections            | 1.57 KB   | 345.15 B   | 19.9          | 1.0
	ember-inflector/index                             | 1.12 KB   | 246.11 B   | 14.2          | 0.7
	ember-inflector/lib/ext/string                    | 783.00 B  | 167.86 B   | 9.7           | 0.5
	ember-inflector/lib/system                        | 452.00 B  | 96.90 B    | 5.6           | 0.3
	ember-inflector/lib/system/string                 | 351.00 B  | 75.24 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize             | 348.00 B  | 74.60 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 66.03 B    | 3.8           | 0.2
	ember-inflector/lib/helpers/singularize           | 271.00 B  | 58.09 B    | 3.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.68 KB'  │
│  compressed  │ '588.05 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.19 KB   | 481.07 B   | 81.8          | 1.4
	@ember-data/debug/setup                           | 499.00 B  | 106.97 B   | 18.2          | 0.3

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.05 KB'  │
│  compressed  │ '231.10 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                          | 1.05 KB   | 231.10 B   | 100.0         | 0.7

Modern Builds

EmberData increased by 82.0 B uncompressed but decreased by 9.0 B compressed

Warnings

The uncompressed size of the package @ember-data/model has increased by 82.0 B.

Changeset


EmberData 159.87 KB +82.0 B (34.27 KB -9.0 B compressed)
    @ember-data/model 13.46 KB +82.0 B (2.88 KB -9.0 B compressed)
        @ember-data/model/-private 12.98 KB +82.0 B (2.78 KB -9.0 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '159.87 KB' │
│ compressed │ '34.27 KB'  │
│  packages  │      9      │
│  modules   │     46      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '68.79 KB' │
│  compressed  │ '14.75 KB' │
│ % Of Library │   '43.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 67.88 KB  | 14.55 KB   | 98.7          | 42.5
	@ember-data/store/index                           | 936.00 B  | 200.66 B   | 1.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.61 KB' │
│  compressed  │ '4.85 KB'  │
│ % Of Library │   '14.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 22.61 KB  | 4.85 KB    | 100.0         | 14.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.32 KB' │
│  compressed  │ '4.14 KB'  │
│ % Of Library │   '12.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.10 KB   | 1.52 KB    | 36.8          | 4.4
	@ember-data/serializer/-private                   | 5.36 KB   | 1.15 KB    | 27.7          | 3.4
	@ember-data/serializer/json-api                   | 3.71 KB   | 813.80 B   | 19.2          | 2.3
	@ember-data/serializer/rest                       | 2.70 KB   | 593.20 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 243.00 B  | 52.09 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.09 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.77 KB' │
│  compressed  │ '3.17 KB'  │
│ % Of Library │   '9.2'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.80 KB   | 1.67 KB    | 52.8          | 4.9
	@ember-data/adapter/-private                      | 3.54 KB   | 776.71 B   | 24.0          | 2.2
	@ember-data/adapter/error                         | 1.91 KB   | 419.98 B   | 13.0          | 1.2
	@ember-data/adapter/json-api                      | 830.00 B  | 177.94 B   | 5.5           | 0.5
	@ember-data/adapter/index                         | 719.00 B  | 154.14 B   | 4.8           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '13.46 KB' │
│  compressed  │ '2.88 KB'  │
│ % Of Library │   '8.4'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 12.98 KB  | 2.78 KB    | 96.5          | 8.1
	@ember-data/model/index                           | 486.00 B  | 104.19 B   | 3.5           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.28 KB' │
│  compressed  │ '1.99 KB' │
│ % Of Library │   '5.8'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 510.02 B   | 25.0          | 1.5
	ember-data/-private                               | 2.02 KB   | 444.41 B   | 21.8          | 1.3
	ember-data/adapters/errors                        | 1.19 KB   | 260.90 B   | 12.8          | 0.7
	ember-data/setup-container                        | 503.00 B  | 107.83 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 68.17 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.74 B    | 2.9           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 53.81 B    | 2.6           | 0.2
	ember-data/adapters/json-api                      | 245.00 B  | 52.52 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.09 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.09 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 51.66 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.80 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.73 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.45 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.59 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.59 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.73 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 34.73 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.90 KB' │
│  compressed  │ '1.69 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.76 KB   | 605.20 B   | 34.9          | 1.7
	ember-inflector/lib/system/inflections            | 1.57 KB   | 345.15 B   | 19.9          | 1.0
	ember-inflector/index                             | 1.12 KB   | 246.11 B   | 14.2          | 0.7
	ember-inflector/lib/ext/string                    | 783.00 B  | 167.86 B   | 9.7           | 0.5
	ember-inflector/lib/system                        | 452.00 B  | 96.90 B    | 5.6           | 0.3
	ember-inflector/lib/system/string                 | 351.00 B  | 75.24 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize             | 348.00 B  | 74.60 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 66.03 B    | 3.8           | 0.2
	ember-inflector/lib/helpers/singularize           | 271.00 B  | 58.09 B    | 3.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.68 KB'  │
│  compressed  │ '588.05 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.19 KB   | 481.07 B   | 81.8          | 1.4
	@ember-data/debug/setup                           | 499.00 B  | 106.97 B   | 18.2          | 0.3

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.05 KB'  │
│  compressed  │ '231.10 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                          | 1.05 KB   | 231.10 B   | 100.0         | 0.7

Modern Builds (No Rollup)

The size of the library EmberData has increased by 82.0 B (5.0 B compressed) which exceeds the failure threshold of 15 bytes.

Warnings

The uncompressed size of the package @ember-data/model has increased by 82.0 B.

Changeset


EmberData 203.94 KB +82.0 B (38.76 KB +5.0 B compressed)
    @ember-data/model 17.4 KB +82.0 B (3.31 KB +5.0 B compressed)
        @ember-data/model/-private/errors 2.03 KB +82.0 B (395.35 B +5.0 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '203.94 KB' │
│ compressed │ '38.76 KB'  │
│  packages  │      9      │
│  modules   │     144     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬─────────────┐
│   (index)    │   Values    │
├──────────────┼─────────────┤
│    bytes     │ '100.85 KB' │
│  compressed  │ '19.17 KB'  │
│ % Of Library │   '49.5'    │
└──────────────┴─────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.37 KB  | 3.30 KB    | 17.2          | 8.5
	@ember-data/store/-private/system/model/internal-model                             | 16.97 KB  | 3.23 KB    | 16.8          | 8.3
	@ember-data/store/-private/system/model/states                                     | 5.44 KB   | 1.03 KB    | 5.4           | 2.7
	@ember-data/store/-private/system/fetch-manager                                    | 4.93 KB   | 958.74 B   | 4.9           | 2.4
	@ember-data/store/-private/system/store/finders                                    | 4.31 KB   | 838.62 B   | 4.3           | 2.1
	@ember-data/store/-private/index                                                   | 4.23 KB   | 822.65 B   | 4.2           | 2.1
	@ember-data/store/-private/system/record-array-manager                             | 3.83 KB   | 744.91 B   | 3.8           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.74 KB   | 727.80 B   | 3.7           | 1.8
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.42 KB   | 664.69 B   | 3.4           | 1.7
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.86 KB   | 557.11 B   | 2.8           | 1.4
	@ember-data/store/-private/system/snapshot                                         | 2.85 KB   | 554.07 B   | 2.8           | 1.4
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.11 KB   | 410.75 B   | 2.1           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.99 KB   | 386.61 B   | 2.0           | 1.0
	@ember-data/store/-private/system/request-cache                                    | 1.87 KB   | 364.37 B   | 1.9           | 0.9
	@ember-data/store/-private/system/schema-definition-service                        | 1.47 KB   | 286.06 B   | 1.5           | 0.7
	@ember-data/store/-private/system/references/has-many                              | 1.46 KB   | 284.92 B   | 1.5           | 0.7
	@ember-data/store/-private/system/relationship-meta                                | 1.45 KB   | 281.69 B   | 1.4           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.26 KB   | 245.19 B   | 1.2           | 0.6
	@ember-data/store/-private/system/references/belongs-to                            | 1.20 KB   | 232.65 B   | 1.2           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.12 KB   | 218.77 B   | 1.1           | 0.6
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 204.90 B   | 1.0           | 0.5
	@ember-data/store/-private/system/internal-model-map                               | 981.00 B  | 186.46 B   | 0.9           | 0.5
	@ember-data/store/index                                                            | 936.00 B  | 177.91 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/record                                | 918.00 B  | 174.49 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 911.00 B  | 173.16 B   | 0.9           | 0.4
	@ember-data/store/-private/system/model/notify-changes                             | 862.00 B  | 163.84 B   | 0.8           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 759.00 B  | 144.26 B   | 0.7           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 143.12 B   | 0.7           | 0.4
	@ember-data/store/-private/system/references/reference                             | 729.00 B  | 138.56 B   | 0.7           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 689.00 B  | 130.96 B   | 0.7           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 113.66 B   | 0.6           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 556.00 B  | 105.68 B   | 0.5           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 506.00 B  | 96.17 B    | 0.5           | 0.2
	@ember-data/store/-private/system/store/common                                     | 499.00 B  | 94.84 B    | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 494.00 B  | 93.89 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 92.56 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 85.53 B    | 0.4           | 0.2
	@ember-data/store/-private/system/diff-array                                       | 438.00 B  | 83.25 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 76.03 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 393.00 B  | 74.70 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 62.15 B    | 0.3           | 0.2
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.06 B    | 0.3           | 0.2
	@ember-data/store/-private/utils/promise-record                                    | 288.00 B  | 54.74 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 268.00 B  | 50.94 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/brand                                             | 258.00 B  | 49.03 B    | 0.2           | 0.1
	@ember-data/store/-private/system/record-data-for                                  | 235.00 B  | 44.66 B    | 0.2           | 0.1
	@ember-data/store/-private/system/ts-upgrade-map                                   | 234.00 B  | 44.47 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.29 B    | 0.2           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 210.00 B  | 39.91 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 193.00 B  | 36.68 B    | 0.2           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 190.00 B  | 36.11 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 136.00 B  | 25.85 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 130.00 B  | 24.71 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 98.00 B   | 18.62 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 96.00 B   | 18.24 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 95.00 B   | 18.05 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 95.00 B   | 18.05 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 90.00 B   | 17.10 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 89.00 B   | 16.91 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 85.00 B   | 16.15 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-instance                           | 85.00 B   | 16.15 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data                               | 81.00 B   | 15.39 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 78.00 B   | 14.82 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/utils                                     | 75.00 B   | 14.25 B    | 0.1           | 0.0

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '26.04 KB' │
│  compressed  │ '4.95 KB'  │
│ % Of Library │   '12.8'   │
└──────────────┴────────────┘
	Module                                                                      | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/relationships/state/relationship           | 8.16 KB   | 1.55 KB    | 31.4          | 4.0
	@ember-data/record-data/-private/record-data                                | 8.11 KB   | 1.54 KB    | 31.1          | 4.0
	@ember-data/record-data/-private/relationships/state/belongs-to             | 3.02 KB   | 587.71 B   | 11.6          | 1.5
	@ember-data/record-data/-private/relationships/state/has-many               | 2.81 KB   | 546.28 B   | 10.8          | 1.4
	@ember-data/record-data/-private/relationships/state/create                 | 1.15 KB   | 223.91 B   | 4.4           | 0.6
	@ember-data/record-data/-private/index                                      | 1023.00 B | 194.44 B   | 3.8           | 0.5
	@ember-data/record-data/-private/ordered-set                                | 598.00 B  | 113.66 B   | 2.2           | 0.3
	@ember-data/record-data/-private/record-data-for                            | 481.00 B  | 91.42 B    | 1.8           | 0.2
	@ember-data/record-data/-private/coerce-id                                  | 406.00 B  | 77.17 B    | 1.5           | 0.2
	@ember-data/record-data/-private/normalize-link                             | 249.00 B  | 47.32 B    | 0.9           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data     | 100.00 B  | 19.00 B    | 0.4           | 0.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.71 KB' │
│  compressed  │ '4.13 KB'  │
│ % Of Library │   '10.6'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.10 KB   | 1.35 KB    | 32.7          | 3.5
	@ember-data/serializer/-private/embedded-records-mixin     | 4.28 KB   | 833.48 B   | 19.7          | 2.1
	@ember-data/serializer/json-api                            | 3.71 KB   | 721.53 B   | 17.1          | 1.8
	@ember-data/serializer/rest                                | 2.70 KB   | 525.94 B   | 12.4          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 229.99 B   | 5.4           | 0.6
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 99.41 B    | 2.4           | 0.3
	@ember-data/serializer/-private/transforms/boolean         | 490.00 B  | 93.13 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 84.77 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 351.00 B  | 66.71 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 286.00 B  | 54.36 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 243.00 B  | 46.18 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 242.00 B  | 45.99 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 40.86 B    | 1.0           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.40 KB' │
│  compressed  │ '3.31 KB'  │
│ % Of Library │   '8.5'    │
└──────────────┴────────────┘
	Module                                                   | Bytes     | Compressed | % of Package  | % Of Library
	------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                         | 6.28 KB   | 1.19 KB    | 36.1          | 3.1
	@ember-data/model/-private/system/many-array             | 2.30 KB   | 447.25 B   | 13.2          | 1.1
	@ember-data/model/-private/errors                        | 2.03 KB   | 395.35 B   | 11.7          | 1.0
	@ember-data/model/-private/index                         | 1.29 KB   | 251.09 B   | 7.4           | 0.6
	@ember-data/model/-private/system/relationships/ext      | 1.19 KB   | 230.94 B   | 6.8           | 0.6
	@ember-data/model/-private/attr                          | 743.00 B  | 141.22 B   | 4.2           | 0.4
	@ember-data/model/-private/belongs-to                    | 663.00 B  | 126.02 B   | 3.7           | 0.3
	@ember-data/model/-private/system/promise-many-array     | 642.00 B  | 122.02 B   | 3.6           | 0.3
	@ember-data/model/-private/has-many                      | 626.00 B  | 118.98 B   | 3.5           | 0.3
	@ember-data/model/index                                  | 486.00 B  | 92.37 B    | 2.7           | 0.2
	@ember-data/model/-private/util                          | 442.00 B  | 84.01 B    | 2.5           | 0.2
	@ember-data/model/-private/system/promise-belongs-to     | 410.00 B  | 77.93 B    | 2.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin        | 404.00 B  | 76.79 B    | 2.3           | 0.2

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '16.81 KB' │
│  compressed  │ '3.19 KB'  │
│ % Of Library │   '8.2'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.80 KB   | 1.48 KB    | 46.4          | 3.8
	@ember-data/adapter/error                                     | 1.91 KB   | 372.36 B   | 11.4          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.80 KB   | 351.07 B   | 10.7          | 0.9
	@ember-data/adapter/-private/index                            | 1.03 KB   | 200.72 B   | 6.1           | 0.5
	@ember-data/adapter/json-api                                  | 830.00 B  | 157.76 B   | 4.8           | 0.4
	@ember-data/adapter/-private/utils/serialize-query-params     | 792.00 B  | 150.54 B   | 4.6           | 0.4
	@ember-data/adapter/index                                     | 719.00 B  | 136.66 B   | 4.2           | 0.3
	@ember-data/adapter/-private/utils/determine-body-promise     | 521.00 B  | 99.02 B    | 3.0           | 0.2
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 91.23 B    | 2.8           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 86.29 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 65.95 B    | 2.0           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 217.00 B  | 41.24 B    | 1.3           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.50 KB' │
│  compressed  │ '1.81 KB' │
│ % Of Library │   '4.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 452.19 B   | 24.5          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 375.21 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 231.32 B   | 12.5          | 0.6
	ember-data/setup-container                        | 503.00 B  | 95.60 B    | 5.2           | 0.2
	ember-data/-private/core                          | 321.00 B  | 61.01 B    | 3.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.44 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.08 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.70 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.56 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.18 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.18 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 45.80 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.04 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.09 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 42.95 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.19 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.19 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.43 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 30.79 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.90 KB' │
│  compressed  │ '1.50 KB' │
│ % Of Library │   '3.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.76 KB   | 536.58 B   | 34.9          | 1.4
	ember-inflector/lib/system/inflections            | 1.57 KB   | 306.02 B   | 19.9          | 0.8
	ember-inflector/index                             | 1.12 KB   | 218.20 B   | 14.2          | 0.5
	ember-inflector/lib/ext/string                    | 783.00 B  | 148.82 B   | 9.7           | 0.4
	ember-inflector/lib/system                        | 452.00 B  | 85.91 B    | 5.6           | 0.2
	ember-inflector/lib/system/string                 | 351.00 B  | 66.71 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize             | 348.00 B  | 66.14 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 58.54 B    | 3.8           | 0.1
	ember-inflector/lib/helpers/singularize           | 271.00 B  | 51.51 B    | 3.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.68 KB'  │
│  compressed  │ '521.38 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.19 KB   | 426.53 B   | 81.8          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 94.84 B    | 18.2          | 0.2

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.05 KB'  │
│  compressed  │ '204.90 B' │
│ % Of Library │   '0.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                          | 1.05 KB   | 204.90 B   | 100.0         | 0.5

@igorT
Copy link
Member

igorT commented Sep 21, 2020

Can you please squash the commits so I can rebase cleanly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing error from Model.errors is not autotracked in ember 3.20.5
4 participants