Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManyArray.flushCanonical should use set method for currentState #2763

Closed
wants to merge 1 commit into from
Closed

ManyArray.flushCanonical should use set method for currentState #2763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ember-data/lib/system/record_arrays/many_array.js
View file
Open in desktop
Expand Up @@ -76,7 +76,7 @@ export default Ember.Object.extend(Ember.MutableArray, Ember.Evented, {
toSet = toSet.concat(newRecords);
this.arrayContentWillChange(0, this.length, this.length);
this.set('length', toSet.length);
this.currentState = toSet;
this.set('currentState', toSet);
this.arrayContentDidChange(0, this.length, this.length);
//TODO Figure out to notify only on additions and maybe only if unloaded
this.relationship.notifyHasManyChanged();
Expand Down