Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization results in the documentation. #3004

Merged
merged 1 commit into from
Apr 17, 2015
Merged

Fix serialization results in the documentation. #3004

merged 1 commit into from
Apr 17, 2015

Conversation

nathanhammond
Copy link
Member

I believe that this is a mistake in the description, but I'm unfamiliar enough with Ember Data to be unsure. :)

@bmac
Copy link
Member

bmac commented Apr 17, 2015

I believe career is correct in this case because the attribute is remapped by the {key: 'career'} option: https://github.com/emberjs/data/pull/3004/files#diff-cce3ad76c2e3801ed1a94bf5276dbbbbR81.

Here is a simple jsbin that demonstrates the example in the docs:
http://emberjs.jsbin.com/lisuyahoma/1/edit?html,css,js,console

It does appear that the firstName and lastName are missing from the serialized example. If you would like to change this pr to add those I would be happy to merge it.

@nathanhammond
Copy link
Member Author

I read it as a deserialize instead of a serialize. :) Patch modified to include additional details.

@bmac
Copy link
Member

bmac commented Apr 17, 2015

Thanks.

bmac added a commit that referenced this pull request Apr 17, 2015
Fix serialization results in the documentation.
@bmac bmac merged commit 65f003a into emberjs:master Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants