Added pushedData hook to root.deleted.uncommitted state. #3031
Conversation
| test("root.deleted.uncommitted supports pushedData", function() { | ||
| equal(typeof get(rootState, "deleted.uncommitted.pushedData"), 'function', | ||
| "root.deleted.uncommitted should be a function"); | ||
| }); |
There was a problem hiding this comment.
Instead of testing that the deleted.uncommitted.pushedData function exists could you add a new test to the model-test.js file that creates a record with an id using store.push, calls record.deleteRecord() to move it into the deleted.uncommitted state then call store.push again with the same id then assert that the record is still in the root.deleted.uncommitted state and no errors are thrown?
This should help make the test more resilient against future refactors.
There was a problem hiding this comment.
Yep good call, will do. I didn't like this approach but wasn't sure how to correctly test it.
|
No idea why Appveyor failed, I think it's due to a npm issue, will try and restart |
|
@igorT Any movement on this PR? |
simonexmachina
force-pushed
the
pushed-data-in-deleted-uncommitted
branch
from
4115cdf
to
556827e
Compare
|
I've improved the test based on the feedback from @bmac. |
|
Looks good to me. |
…mitted Added pushedData hook to root.deleted.uncommitted state.
Resolves #3023.