[WIP] json api errors #3194
Merged
[WIP] json api errors #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (status === 422) { | ||
| var errors = []; | ||
|
|
||
| Object.keys(payload.errors).forEach(function(key) { |
There was a problem hiding this comment.
We should probably check if payload.errors is there or not
tchak
force-pushed
the
json-api-errors
branch
4 times, most recently
from
5385889
to
7fe469d
Compare
tchak
force-pushed
the
json-api-errors
branch
24 times, most recently
from
4c91a8f
to
8b8f6b3
Compare
| export function errorsHashToArray(errors) { | ||
| let out = []; | ||
|
|
||
| if (Ember.isPresent(errors)) { |
There was a problem hiding this comment.
should probably use Ember.keys + a for loop
|
lgtm |
|
Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR normalize internal representation of errors in ember data. It will align the representation of errors with json api spec errors
It do not change public api (
errorsobject) for invalid errorsWe are deprecating
ajaxSuccessandajaxErrorin favor ofhandleRequest. The main goal is to decoupleRESTAdapterfromjQuery.ajax.