Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat empty strings in ids the same as null or undefined #3253

Merged
merged 1 commit into from Jun 8, 2015
Merged

Treat empty strings in ids the same as null or undefined #3253

merged 1 commit into from Jun 8, 2015

Conversation

pangratz
Copy link
Member

@pangratz pangratz commented Jun 8, 2015

Treats empty strings in ids the same as null or undefined.


This is the rebased version of #2352

@igorT
Copy link
Member

igorT commented Jun 8, 2015

Thanks!

@pangratz
Copy link
Member Author

pangratz commented Jun 8, 2015

Fixing the failing tests ...

@pangratz pangratz changed the title Check for empty string Treat empty strings in ids the same as null or undefined Jun 8, 2015
fivetanley added a commit that referenced this pull request Jun 8, 2015
Treat empty strings in ids the same as null or undefined
@fivetanley fivetanley merged commit 2d5c6b1 into emberjs:master Jun 8, 2015
@pangratz pangratz deleted the empty-id branch June 8, 2015 13:14
@pangratz pangratz mentioned this pull request Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants