Allow the store to pass adapter options to the adapter #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -494,8 +494,8 @@ var Model = Ember.Object.extend(Ember.Evented, { | |||
|
|
|||
| @method deleteRecord | |||
| */ | |||
| deleteRecord: function() { | |||
| this._internalModel.deleteRecord(); | |||
| deleteRecord: function(options) { | |||
There was a problem hiding this comment.
why does deleteRecord take options?
There was a problem hiding this comment.
This is a mistake. I will undo this.
bmac
force-pushed
the
snapshot-array
branch
2 times, most recently
from
13000d1
to
4e73e0a
Compare
|
@igorT I have updated this pr. |
| @param {Object} meta | ||
| */ | ||
| function SnapshotRecordArray(snapshots, meta, adapterOptions) { | ||
| this.snapshots = snapshots; |
|
looks great otherwise |
Add a SnapshotRecordArray object used for passing snapshots, meta and adapterOptions to the adapter.
igorT
added a commit
that referenced
this pull request
Jun 13, 2015
Allow the store to pass adapter options to the adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr also introduces a
SnapshotRecordArrayobject to pass snapshots, adapterOptions and meta into the adapter findAll.