Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement adapter reload hooks from RFC #61 #3324

Merged
merged 1 commit into from
Jun 15, 2015
Merged

Conversation

bmac
Copy link
Member

@bmac bmac commented Jun 13, 2015

This pr implements shouldReloadRecord and shouldBackgroundReloadRecord hooks from emberjs/rfcs#61.

It is built on top of the changes made in pr #3312

@return {Boolean}
*/
shouldBackgroundReloadRecord: function(store, snapshot) {
//Ember.deprecate('The default behavior of `shouldBackgroundReloadRecord` will change in Ember Data 2.0 to always return true. If you would like to preserve the current behavior please override `shouldBackgroundReloadRecord` in you adapter:application and return false.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why commented out?

@bmac bmac force-pushed the should-reload branch 5 times, most recently from a2ca927 to 02a33b6 Compare June 15, 2015 20:10
…adRecord

Implement Adapter#shouldReloadAll and Adapter#shouldBackgroundReloadAll
bmac added a commit that referenced this pull request Jun 15, 2015
Implement adapter reload hooks from RFC #61
@bmac bmac merged commit d6ec6f8 into emberjs:master Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants