Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate store.pushMany in favor of store.push #3326

Merged
merged 1 commit into from
Jun 13, 2015

Conversation

mikehollis
Copy link
Contributor

This fixes #3246

Deprecates store.pushMany in favor of store.push

@wecc
Copy link
Contributor

wecc commented Jun 13, 2015

LGTM, not sure why Travis fails.

@fivetanley
Copy link
Member

Seems to die on canary. To debug this locally, you can use http://localhost:4200/?nojshint=true&emberchannel=canary after running npm start

@mikehollis
Copy link
Contributor Author

@fivetanley - thanks for the tip, although it's all green on my local machine.

I tried running npm run-script test:canary on my local machine, but it seems to hang

Any ideas?

@fivetanley
Copy link
Member

Probably phantomJS related :( PhantomJS lacks some ES5 APIs out of the box. Are you on OSX?

@mikehollis
Copy link
Contributor Author

I am on OSX in fact, but I have a Windows VM handy... anything I can do to replicate the error and solve it?

@fivetanley
Copy link
Member

The reason I ask about OSX is that it's currently the easiest platform to try out phantomjs 2 on. If you run brew update && brew install phantomjs (assuming you have homebrew), that should get you 2.0. run rm -rf node_modules/phantomjs and then start the server again.

That will at least let us know if it's a PhantomJS 1.9 issue and/or a PhantomJS 2.0 issue.

@mikehollis
Copy link
Contributor Author

I had a fully green test suite before I upgraded, and then following your steps I still have a fully green test suite.

edit: seems like I had phantomjs installed through npm globally. Let me retry

@fivetanley
Copy link
Member

@mikehollis sorry to lead you on a goose chase, seems to be a blip on the phantomjs build. Travis is passing again.

@fivetanley
Copy link
Member

Thanks! 🎉

fivetanley added a commit that referenced this pull request Jun 13, 2015
Deprecate store.pushMany in favor of store.push
@fivetanley fivetanley merged commit 0d59b9c into emberjs:master Jun 13, 2015
@mikehollis
Copy link
Contributor Author

No worries @fivetanley -- I learned some things just by going through that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate store.pushMany
3 participants