Replace Ember.EnumerableUtils with Ember.ArrayPollyfills. #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember.EnumerableUtils is deprecated. Ember.ArrayPollyfills is private. They are both going away in Ember 2.0 but Ember.ArrayPollyfills doesn't introduce console noise in user's code
igorT
added a commit
that referenced
this pull request
Jun 15, 2015
Replace Ember.EnumerableUtils with Ember.ArrayPollyfills.
|
Thank you @bmac |
|
these are also gone, ES5 has all these functions. |
|
@stefanpenner the commit message agrees with you |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember.EnumerableUtils is deprecated. Ember.ArrayPollyfills is
private. They are both going away in Ember 2.0 but
Ember.ArrayPollyfills doesn't introduce console noise in user's code
cc @fivetanley @igorT
@igorT this would just be for the 1.13 release as I've seen a bunch of confusion in slack about Ember deprecation warnings originating from Ember Data's use of
EnumerableUtils.