[REGRESSION release] Make meta available with new Serializer API #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wecc
force-pushed
the
metadata-regression
branch
from
f62ce53
to
5babe47
Compare
| */ | ||
| metadataFor: function(modelName) { | ||
| Ember.deprecate("`store.metadataFor()` has been deprecated. You can use `.get('meta')` on relationships and arrays returned from `store.query()`."); | ||
| return this._metadataFor(...arguments); |
wecc
force-pushed
the
metadata-regression
branch
from
5babe47
to
6e853b4
Compare
igorT
added a commit
that referenced
this pull request
Jun 20, 2015
[REGRESSION release] Make meta available with new Serializer API
|
if it's being deprecated, what's the new way? |
|
@JKGisMe You can get meta off of relationships plus arrays returned from |
|
What about "meta" on the top level (not inside relationships)? What is the correct replacement of I've provided the full example/question in another ticket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to deprecate
store.metadataForandstore.setMetadataForwhen releasing 1.13. We also failed to keep backwards compatibility with metadata for users that are preparing for 2.0 and switches over to the new Serializer API.This PR fixes that regression and correctly deprecates
store.metadataForandstore.setMetadataFor.Fixes #3391