Deprecate error property #3560
Deprecate error property #3560
Conversation
| if (arguments.length === 2) { | ||
| this._error = error; | ||
| } | ||
| Ember.deprecate('DS.Model#error has been deprecated please use adapterError instead'); |
There was a problem hiding this comment.
This seems pretty frequent and i imagine users will disable warnings altogether as their apps will get super noisy. We should probably deprecate once.
There was a problem hiding this comment.
Make sense, I will update later tonight.
tchak
force-pushed
the
deprecate-error
branch
2 times, most recently
from
cd6acb1
to
cdbac46
Compare
|
@fivetanley updated for only show deprecation once |
|
come on appveyor... |
| return Ember.get(this, 'adapterError'); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Lets just make this a normal computed property so it can be overridden. Part of the original reason for renaming error to adapterError was because people were defining an error attribute on their models. That should still be allowed.
There was a problem hiding this comment.
right, but now that I am thinking, if someone defined error attribute on the model, the deprecation will not work anyway. Not sure what to do about it. Maybe it is double, but I have no idea how to define a property that can be overridden but will still run some code on get...
There was a problem hiding this comment.
If someone defines an error attribute I don't think we should log the deprecation because presumably they want to use the error property as an attribute and are not accidentally trying to reference adapterError.
There was a problem hiding this comment.
@bmac this is what I assumed. PR updated.
| } | ||
| return Ember.get(this, 'adapterError'); | ||
| } | ||
| }), |
There was a problem hiding this comment.
Does this computed need a dependency on adapterError or should it be marked volatile?
There was a problem hiding this comment.
off cours... Sorry for the mess with this thing. Should have been an easy one. Updated...
|
Tested and it works great. 👍 |
@bmac as discussed, here is the deprecation for
errorproperty