[BUGFIX release] Fix unconsistent behavior in Model.changedAttributes #3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -611,7 +613,9 @@ var Model = Ember.Object.extend(Ember.Evented, { | |||
| */ | |||
| changedAttributes: function() { | |||
| var oldData = get(this._internalModel, '_data'); | |||
| var newData = get(this._internalModel, '_attributes'); | |||
| var currentData = get(this._internalModel, '_attributes'); | |||
There was a problem hiding this comment.
BTW, I wonder why here we have to use get instead of just this._internalModel._whatever
cibernox
force-pushed
the
fix_changed_attributes
branch
from
dff2f0b
to
2a19c7b
Compare
|
Updated |
|
Looks good. 👍 |
cibernox
force-pushed
the
fix_changed_attributes
branch
from
2a19c7b
to
e057089
Compare
|
Fixed a typo. Now it's done |
bmac
added a commit
that referenced
this pull request
Jul 25, 2015
[BUGFIX release] Fix unconsistent behavior in Model.changedAttributes
|
Thanks @cibernox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3579