Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Remove duplicate test for creating record #3820

Merged
merged 1 commit into from
Oct 6, 2015
Merged

[CLEANUP] Remove duplicate test for creating record #3820

merged 1 commit into from
Oct 6, 2015

Conversation

pangratz
Copy link
Member

@pangratz pangratz commented Oct 6, 2015

In the refactor in #3033 the test for passing a camelCased model name
has been renamed due to deprecations to a dash-erized model name. This
introduced the exact same test.


The source code in lines 60-91 and the lines 93-125 are equal: https://www.diffchecker.com/xcehwtlm

In the refactor in #3033 the test for passing a camelCased model name
has been renamed due to deprecations to a dash-erized model name. This
introduced the exact same test.
bmac added a commit that referenced this pull request Oct 6, 2015
[CLEANUP] Remove duplicate test for creating record
@bmac bmac merged commit 1e1c491 into emberjs:master Oct 6, 2015
@bmac
Copy link
Member

bmac commented Oct 6, 2015

Thanks @pangratz

@pangratz pangratz deleted the remove-duplicate-test branch October 6, 2015 13:44
@pangratz
Copy link
Member Author

pangratz commented Oct 6, 2015

💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants