Remove references to findQuery #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`findQuery` was deprecated back in 1.0 and removed for 2.0 A test file was also removed that was referencing `findQuery` as well as `RestAdapter#find` (which was also deprecated and removed). In addition to referencing code that was no longer present, this test file was missing the `-test` in its name and has not been running as part of the build. It did not pass before or after these changes.
|
Thanks |
marpo60
added a commit
to collectrium/ember-data-socketio-adapter
that referenced
this pull request
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findQuerywas deprecated back in 1.0 and removed for 2.0 (#3235)A test file was also removed that was referencing
findQueryas wellas
RestAdapter#find, which was also deprecated and removed.(#3306)In addition to referencing code that was no longer present, this test
file was missing the
-testin its name and has not been running aspart of the build. It did not pass before or after these changes.