[BUGFIX beta] rollbackAttributes() works after multiple failed saves #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am 👍 with this one. Will merge it after #3859 |
|
@pangratz can you rebase to make sure tests are ok? |
A rollback of dirty attributes didn't work correctly when a model is saved more than 1 time and the save fails. The issue is that the `exit` handler on the invalid state - which is called when the model is saved again and it is transitioned into the inFlight state - clears the `_inFlightAttributes` which unfortunately wipes all the data needed to rollback attributes. The exit handler has been implemented in the course of #1755, but the reported issue in that PR seems to be fixed ever since elsewhere in the code base, since the added test back test still is green.
|
I ❤️ AppVeyor. |
tchak
added a commit
that referenced
this pull request
Oct 15, 2015
…rollbackAttribute [BUGFIX beta] rollbackAttributes() works after multiple failed saves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rollback of dirty attributes didn't work correctly when a model is
saved more than 1 time and the save fails. The issue is that the
exithandler on the invalid state - which is called when the model is saved
again and it is transitioned into the inFlight state - clears the
_inFlightAttributeswhich unfortunately wipes all the data needed torollback attributes.
The exit handler has been implemented in the course of #1755, but the
reported issue in that PR seems to be fixed ever since elsewhere in the
code base, since the added test back test still is green.
This depends on
#3856#3859 and closes #3677.