New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow store.push to accept { data: null } #3866

Merged
merged 1 commit into from Oct 29, 2015

Conversation

Projects
None yet
4 participants
@bmac
Member

bmac commented Oct 16, 2015

Closes #3790

cc @wecc could review this pr?

@igorT

This comment has been minimized.

Show comment
Hide comment
@igorT

igorT Oct 26, 2015

Member

@wecc are we good here?

Member

igorT commented Oct 26, 2015

@wecc are we good here?

@wecc

This comment has been minimized.

Show comment
Hide comment
@wecc

wecc Oct 26, 2015

Contributor

LGTM!

@bmac squash?

Contributor

wecc commented Oct 26, 2015

LGTM!

@bmac squash?

@bmac

This comment has been minimized.

Show comment
Hide comment
@bmac

bmac Oct 28, 2015

Member

@wecc squashed.

Member

bmac commented Oct 28, 2015

@wecc squashed.

igorT added a commit that referenced this pull request Oct 29, 2015

Merge pull request #3866 from bmac/issue-3790
Allow store.push to accept { data: null }

@igorT igorT merged commit 31bf071 into emberjs:master Oct 29, 2015

1 of 2 checks passed

continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@igorT

This comment has been minimized.

Show comment
Hide comment
@igorT

igorT Oct 29, 2015

Member

Maybe a warning for people upgrading that we switched to json api?

Member

igorT commented Oct 29, 2015

Maybe a warning for people upgrading that we switched to json api?

@jherdman

This comment has been minimized.

Show comment
Hide comment
@jherdman

jherdman Nov 17, 2015

Contributor

Would it be possible to back-port this to 2.2.0?

Contributor

jherdman commented Nov 17, 2015

Would it be possible to back-port this to 2.2.0?

@bmac

This comment has been minimized.

Show comment
Hide comment
@bmac

bmac Nov 17, 2015

Member

@jherdman yes I can release a 2.2.1 tomorrow with this fix.

Member

bmac commented Nov 17, 2015

@jherdman yes I can release a 2.2.1 tomorrow with this fix.

@bmac bmac deleted the bmac:issue-3790 branch Nov 25, 2015

@bmac

This comment has been minimized.

Show comment
Hide comment
@bmac

bmac Nov 25, 2015

Member

Sorry for the delay @jherdman. I just published 2.2.1 with this commit.

Member

bmac commented Nov 25, 2015

Sorry for the delay @jherdman. I just published 2.2.1 with this commit.

@jherdman

This comment has been minimized.

Show comment
Hide comment
@jherdman

jherdman Nov 25, 2015

Contributor

No worries! I greatly appreciate the release.

Contributor

jherdman commented Nov 25, 2015

No worries! I greatly appreciate the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment