[BUGFIX beta] serialize type for embedded, polymorphic belongsTo #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| vicinity: get(tom, "secretLab").get("vicinity"), | ||
| infiltrated: true | ||
| } | ||
| }); |
There was a problem hiding this comment.
I am not sure if this is the way this should work. Now that I think about it, this probably should be a type property inside the secretLab object instead of the secretLabType, right?
| run(function() { | ||
| tom = env.store.createRecord( | ||
| 'super-villain', | ||
| { firstName: "Tom", lastName: "Dale", id: "1", |
There was a problem hiding this comment.
can we clean up the formatting here a bit? it'd be preferable for this to span multiple lines:
{
firstName: "tom",
lastName: "Dale",
id: "1",
}
This fixes the issue where the `serializePolymorphicType` hook on the serializer hasn't been invoked when an embedded, polymorphic belongsTo relationship is serialized.
bmac
added a commit
that referenced
this pull request
Nov 11, 2015
…phic-belongsTo [BUGFIX beta] serialize type for embedded, polymorphic belongsTo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the
serializePolymorphicTypehook on theserializer hasn't been invoked when an embedded, polymorphic belongsTo
relationship is serialized.
This issue has been reported in #3871 (though for ember-data
v1.13.8).