Friendly Errors #3930
Friendly Errors #3930
Conversation
|
@bmac this is a very early cut (missing tests entirely for instance!) but I'm wondering how you feel about this approach? Hopefully this is enough to iterate on though (I'm working on adding tests etc so feel free to just comment and I'll handle the code part, I'm sure you're plenty busy enough already!) Thanks again! |
|
This is awesome. |
|
Aww shucks 😊 Is there anything more I can do that's useful? Or is it looking OK?
|
|
Oh yes! Still missing tests, of course - I just wanted to check the Tests incoming. I'll sing out if I hit issues. Thanks!
|
|
LGTM 👍 |
|
@fivetanley @tchak have added tests now, Travis seems to be having issues at the mo but they run in the browser for me locally :D |
|
@nikz Do you mind squashing this pr into 1 commit? |
| @@ -0,0 +1,52 @@ | |||
| import setupStore from 'dummy/tests/helpers/store'; | |||
| /* import Ember from 'ember'; */ | |||
|
@bmac of course, sorry, how messy of me! 🛀 Cleaned that up now :) EDIT: Apart from that nasty merge commit arghhhh. |
|
@bmac there we go, one single commit that's fast-forward on current master :) |
|
Thanks @nikz |
|
Yay! Thanks team 🙌
|
| @param {Number} status | ||
| @param {Object} headers | ||
| @param {Object} payload | ||
| @return {Object} request information |
There was a problem hiding this comment.
This should be a param, and the return a string.
…nging in RESTAdapter's handleResponse function emberjs/data#3930, pass along requestData as argument in active-model-adapter handleResponse override method as well as fix handleResponse - returns ajax response if not 422 response test
…ng in RESTAdapter's handleResponse function emberjs/data#3930, pass along requestData as argument in active-model-adapter handleResponse override method as well as fix handleResponse - returns ajax response if not 422 response test
…ng in RESTAdapter's handleResponse function emberjs/data#3930, pass along requestData as argument in active-model-adapter handleResponse override method as well as fix handleResponse - returns ajax response if not 422 response test (#83)
This is an initial PR to iterate on "friendly" (more detailed) error messages for Ember Data, as per RFC101
(emberjs/rfcs#101)