New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly Errors #3930

Merged
merged 1 commit into from Dec 9, 2015

Conversation

Projects
None yet
7 participants
@nikz
Contributor

nikz commented Nov 13, 2015

This is an initial PR to iterate on "friendly" (more detailed) error messages for Ember Data, as per RFC101

(emberjs/rfcs#101)

@nikz

This comment has been minimized.

Show comment
Hide comment
@nikz

nikz Nov 13, 2015

Contributor

@bmac this is a very early cut (missing tests entirely for instance!) but I'm wondering how you feel about this approach?

Hopefully this is enough to iterate on though (I'm working on adding tests etc so feel free to just comment and I'll handle the code part, I'm sure you're plenty busy enough already!)

Thanks again!

Contributor

nikz commented Nov 13, 2015

@bmac this is a very early cut (missing tests entirely for instance!) but I'm wondering how you feel about this approach?

Hopefully this is enough to iterate on though (I'm working on adding tests etc so feel free to just comment and I'll handle the code part, I'm sure you're plenty busy enough already!)

Thanks again!

@tomdale

This comment has been minimized.

Show comment
Hide comment
@tomdale

tomdale Dec 2, 2015

Member

This is awesome.

Member

tomdale commented Dec 2, 2015

This is awesome.

@nikz

This comment has been minimized.

Show comment
Hide comment
@nikz

nikz Dec 2, 2015

Contributor

Aww shucks 😊

Is there anything more I can do that's useful? Or is it looking OK?
On Wed, 2 Dec 2015 at 18:31, Tom Dale notifications@github.com wrote:

This is awesome.


Reply to this email directly or view it on GitHub
#3930 (comment).

Contributor

nikz commented Dec 2, 2015

Aww shucks 😊

Is there anything more I can do that's useful? Or is it looking OK?
On Wed, 2 Dec 2015 at 18:31, Tom Dale notifications@github.com wrote:

This is awesome.


Reply to this email directly or view it on GitHub
#3930 (comment).

@fivetanley

This comment has been minimized.

Show comment
Hide comment
@fivetanley

fivetanley Dec 2, 2015

Member

@nikz We are big fans of this commit. However, we would like to add some tests to this so we don't regress this functionality in the future. I am happy to help if you need help getting started writing a test for this.

@tchak Can you give this and the RFC a glance over?

Member

fivetanley commented Dec 2, 2015

@nikz We are big fans of this commit. However, we would like to add some tests to this so we don't regress this functionality in the future. I am happy to help if you need help getting started writing a test for this.

@tchak Can you give this and the RFC a glance over?

@nikz

This comment has been minimized.

Show comment
Hide comment
@nikz

nikz Dec 2, 2015

Contributor

Oh yes! Still missing tests, of course - I just wanted to check the
implementation wasn't completely off base.

Tests incoming. I'll sing out if I hit issues. Thanks!
On Wed, 2 Dec 2015 at 18:33, Stanley Stuart notifications@github.com
wrote:

@nikz https://github.com/nikz We are a big fan of this commit. However,
we would like to add some tests to this so we don't regress this
functionality in the future. I am happy to help if you need help getting
started writing a test for this.

@tchak https://github.com/tchak Can you give this and the RFC a glance
over?


Reply to this email directly or view it on GitHub
#3930 (comment).

Contributor

nikz commented Dec 2, 2015

Oh yes! Still missing tests, of course - I just wanted to check the
implementation wasn't completely off base.

Tests incoming. I'll sing out if I hit issues. Thanks!
On Wed, 2 Dec 2015 at 18:33, Stanley Stuart notifications@github.com
wrote:

@nikz https://github.com/nikz We are a big fan of this commit. However,
we would like to add some tests to this so we don't regress this
functionality in the future. I am happy to help if you need help getting
started writing a test for this.

@tchak https://github.com/tchak Can you give this and the RFC a glance
over?


Reply to this email directly or view it on GitHub
#3930 (comment).

@tchak

This comment has been minimized.

Show comment
Hide comment
@tchak

tchak Dec 3, 2015

Member

LGTM 👍

Member

tchak commented Dec 3, 2015

LGTM 👍

@nikz

This comment has been minimized.

Show comment
Hide comment
@nikz

nikz Dec 4, 2015

Contributor

@fivetanley @tchak have added tests now, Travis seems to be having issues at the mo but they run in the browser for me locally :D

Contributor

nikz commented Dec 4, 2015

@fivetanley @tchak have added tests now, Travis seems to be having issues at the mo but they run in the browser for me locally :D

@bmac

This comment has been minimized.

Show comment
Hide comment
@bmac

bmac Dec 4, 2015

Member

@nikz Do you mind squashing this pr into 1 commit?

Member

bmac commented Dec 4, 2015

@nikz Do you mind squashing this pr into 1 commit?

@nikz

This comment has been minimized.

Show comment
Hide comment
@nikz

nikz Dec 4, 2015

Contributor

@bmac of course, sorry, how messy of me!

🛀 Cleaned that up now :)

EDIT: Apart from that nasty merge commit arghhhh.

Contributor

nikz commented Dec 4, 2015

@bmac of course, sorry, how messy of me!

🛀 Cleaned that up now :)

EDIT: Apart from that nasty merge commit arghhhh.

@nikz

This comment has been minimized.

Show comment
Hide comment
@nikz

nikz Dec 4, 2015

Contributor

@bmac there we go, one single commit that's fast-forward on current master :)

Contributor

nikz commented Dec 4, 2015

@bmac there we go, one single commit that's fast-forward on current master :)

bmac added a commit that referenced this pull request Dec 9, 2015

@bmac bmac merged commit c92b4f8 into emberjs:master Dec 9, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bmac

This comment has been minimized.

Show comment
Hide comment
@bmac

bmac Dec 9, 2015

Member

Thanks @nikz

Member

bmac commented Dec 9, 2015

Thanks @nikz

@nikz

This comment has been minimized.

Show comment
Hide comment
@nikz

nikz Dec 9, 2015

Contributor

Yay! Thanks team 🙌
On Wed, 9 Dec 2015 at 19:23, Brendan McLoughlin notifications@github.com
wrote:

Thanks @nikz https://github.com/nikz


Reply to this email directly or view it on GitHub
#3930 (comment).

Contributor

nikz commented Dec 9, 2015

Yay! Thanks team 🙌
On Wed, 9 Dec 2015 at 19:23, Brendan McLoughlin notifications@github.com
wrote:

Thanks @nikz https://github.com/nikz


Reply to this email directly or view it on GitHub
#3930 (comment).

@fivetanley fivetanley referenced this pull request Jan 6, 2016

Closed

Friendly Errors #101

@param {Number} status
@param {Object} headers
@param {Object} payload
@return {Object} request information

This comment has been minimized.

@knownasilya

knownasilya Mar 1, 2016

Contributor

This should be a param, and the return a string.

@knownasilya

knownasilya Mar 1, 2016

Contributor

This should be a param, and the return a string.

This comment has been minimized.

@pangratz

pangratz Mar 1, 2016

Member

Good catch. Wanna submit a PR?

@pangratz

pangratz Mar 1, 2016

Member

Good catch. Wanna submit a PR?

This comment has been minimized.

@knownasilya

knownasilya Mar 1, 2016

Contributor

Sure

@knownasilya

knownasilya Mar 1, 2016

Contributor

Sure

This comment has been minimized.

@knownasilya
@knownasilya

knownasilya Mar 1, 2016

Contributor

jcope2013 added a commit to jcope2013/active-model-adapter that referenced this pull request Apr 21, 2016

Fix's a regression in ember-data >= 2.4.0 related to arguments changi…
…nging in RESTAdapter's handleResponse function emberjs/data#3930, pass along requestData as argument in active-model-adapter handleResponse override method as well as fix handleResponse - returns ajax response if not 422 response test

jcope2013 added a commit to jcope2013/active-model-adapter that referenced this pull request Apr 21, 2016

Fix's a regression in ember-data >= 2.4.0 related to arguments changi…
…ng in RESTAdapter's handleResponse function emberjs/data#3930, pass along requestData as argument in active-model-adapter handleResponse override method as well as fix handleResponse - returns ajax response if not 422 response test

fivetanley added a commit to ember-data/active-model-adapter that referenced this pull request May 24, 2016

Fix's a regression in ember-data >= 2.4.0 related to arguments changi…
…ng in RESTAdapter's handleResponse function emberjs/data#3930, pass along requestData as argument in active-model-adapter handleResponse override method as well as fix handleResponse - returns ajax response if not 422 response test (#83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment