Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] use debug helpers from ember-data/debug #3973

Merged
merged 1 commit into from
Dec 7, 2015
Merged

[CLEANUP] use debug helpers from ember-data/debug #3973

merged 1 commit into from
Dec 7, 2015

Conversation

pangratz
Copy link
Member

@pangratz pangratz commented Dec 7, 2015

By this, the calls to assert, warn etcetera are corectly stripped
when a new production build is created.

cc @fivetanley

@fivetanley
Copy link
Member

LGTM, although I don't think this actually removes them quite yet because we don't have any broccoli modules for that I think.

@fivetanley
Copy link
Member

Appveyor is failing due to some syntax errors.

By this, the calls to `assert`, `warn` etcetera are corectly stripped
when a new production build is created.
@pangratz
Copy link
Member Author

pangratz commented Dec 7, 2015

although I don't think this actually removes them quite yet because we don't have any broccoli modules for that I think.

Hmm, I am not sure. Doing a ember build --environment=production and searching for assert shows that dist/globals/ember-data.js contains the calls, whereas dist/globals/ember-data.prod.js doesn't. So it seems that they are removed, right?

@fivetanley
Copy link
Member

I barely remember doing this, but here we are :p https://github.com/emberjs/data/blob/master/lib/javascripts.js#L60

@pangratz
Copy link
Member Author

pangratz commented Dec 7, 2015

Hooray 🎉

fivetanley added a commit that referenced this pull request Dec 7, 2015
[CLEANUP] use debug helpers from ember-data/debug
@fivetanley fivetanley merged commit 67bb2e6 into emberjs:master Dec 7, 2015
@pangratz pangratz deleted the fix-debug-imports branch December 8, 2015 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants